Issue 7514005: slight HGraph::CreateGraph refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7514005: slight HGraph::CreateGraph refactor (Closed)

Created:
9 years, 5 months ago by wingo

Modified:
9 years, 5 months ago

Reviewers:
fschneider, Kevin Millikin (Chromium), Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

slight HGraph::CreateGraph refactor * src/hydrogen.h (HGraph): Privatize MarkAsDeoptimizingRecursively. Add PropagateDeoptimizingMark as the interface. * src/hydrogen.cc (AssignDominators): Add a comment. (PropagateDeoptimizingMark): Move MarkAsDeoptimizingRecursively call out of AssignDominators, and here into a new phase. (CreateGraph): Call PropagateDeoptimizingMark. BUG= TEST=

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	src/hydrogen.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	src/hydrogen.cc	View		3 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks.

I'll land it.

Expand Messages | Collapse Messages