Issue 7511014: Define Chromoting's differ block size in one (and only one) place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7511014: Define Chromoting's differ block size in one (and only one) place. (Closed)

Created:
9 years, 4 months ago by garykac

Modified:
9 years, 4 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Define Chromoting's differ block size in one (and only one) place. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95475

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Patch Set 3 : update copyright #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -20 lines)			Patch
M	remoting/host/differ.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	remoting/host/differ.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/differ_block.h	View	1 2	2 chunks	+6 lines, -4 lines	0 comments	Download
M	remoting/host/differ_block.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/host/differ_block_sse2.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/differ_block_unittest.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

LGTM with one nit http://codereview.chromium.org/7511014/diff/1/remoting/host/differ_block.h File remoting/host/differ_block.h (right): http://codereview.chromium.org/7511014/diff/1/remoting/host/differ_block.h#newcode13 remoting/host/differ_block.h:13: // This must be a ...

9 years, 4 months ago (2011-08-04 18:21:41 UTC) #2

garykac

9 years, 4 months ago (2011-08-04 20:07:55 UTC) #3

http://codereview.chromium.org/7511014/diff/1/remoting/host/differ_block.h
File remoting/host/differ_block.h (right):

http://codereview.chromium.org/7511014/diff/1/remoting/host/differ_block.h#ne...
remoting/host/differ_block.h:13: // This must be a multiple of sizeof(uint64).
On 2011/08/04 18:21:41, sergeyu wrote:
> nit: s/sizeof(uint64)/8/

Done.

Expand Messages | Collapse Messages