[Sync] Refactor data type configuration/activation/deactivation

chrome/browser/sync/profile_sync_service.h

Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index f94faa598b7f5c3a1b4dcf3176c1e3a53a2e32aa..0a8d90cd2e4202ac5f78520856244469c6df1de2 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -389,13 +389,12 @@ class ProfileSyncService : public browser_sync::SyncFrontend,
   // remove this function.
   void GetModelSafeRoutingInfo(browser_sync::ModelSafeRoutingInfo* out);
 
+  // Overridden by tests.
   // TODO(zea): Remove these and have the dtc's call directly into the SBH.
   virtual void ActivateDataType(
-      browser_sync::DataTypeController* data_type_controller,
-      browser_sync::ChangeProcessor* change_processor);
-  virtual void DeactivateDataType(
-      browser_sync::DataTypeController* data_type_controller,
+      syncable::ModelType type, browser_sync::ModelSafeGroup group,
       browser_sync::ChangeProcessor* change_processor);
+  virtual void DeactivateDataType(syncable::ModelType type);

[tim (not reviewing), 2011/08/10 23:39:08]

See that todo up there? ;)

[akalin, 2011/08/10 23:41:49]

Future CL.  If I remove these, then I'd have to somehow get the backend to the
DTCs *and* fix tests.  This is already a yak. :(

 
   // NotificationObserver implementation.
   virtual void Observe(int type,