Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc

Issue 7511004: [Sync] Refactor data type configuration/activation/deactivation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests, address comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
index f3f88e6e7e3cb359d43052b35acc19cc00be872c..f975491a32351e7fd8633b2668b999a0dca461aa 100644
--- a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
@@ -127,12 +127,12 @@ class AutofillDataTypeControllerTest : public TestingBrowserProcessTest {
WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true)));
EXPECT_CALL(*model_associator_, AssociateModels(_)).
WillRepeatedly(Return(true));
- EXPECT_CALL(service_, ActivateDataType(_, _));
+ EXPECT_CALL(service_, ActivateDataType(_, _, _));
EXPECT_CALL(*change_processor_, IsRunning()).WillRepeatedly(Return(true));
}
void SetStopExpectations() {
- EXPECT_CALL(service_, DeactivateDataType(_, _));
+ EXPECT_CALL(service_, DeactivateDataType(_));
EXPECT_CALL(*model_associator_, DisassociateModels(_));
}
@@ -182,7 +182,7 @@ TEST_F(AutofillDataTypeControllerTest, AbortWhilePDMStarting) {
autofill_dtc_->Start(NewCallback(&start_callback_, &StartCallback::Run));
EXPECT_EQ(DataTypeController::MODEL_STARTING, autofill_dtc_->state());
- EXPECT_CALL(service_, DeactivateDataType(_, _)).Times(0);
+ EXPECT_CALL(service_, DeactivateDataType(_)).Times(0);
EXPECT_CALL(start_callback_, Run(DataTypeController::ABORTED, _));
autofill_dtc_->Stop();
EXPECT_EQ(DataTypeController::NOT_RUNNING, autofill_dtc_->state());
@@ -200,7 +200,7 @@ TEST_F(AutofillDataTypeControllerTest, AbortWhileWDSStarting) {
autofill_dtc_->Start(NewCallback(&start_callback_, &StartCallback::Run));
EXPECT_EQ(DataTypeController::MODEL_STARTING, autofill_dtc_->state());
- EXPECT_CALL(service_, DeactivateDataType(_, _)).Times(0);
+ EXPECT_CALL(service_, DeactivateDataType(_)).Times(0);
EXPECT_CALL(start_callback_, Run(DataTypeController::ABORTED, _));
autofill_dtc_->Stop();
EXPECT_EQ(DataTypeController::NOT_RUNNING, autofill_dtc_->state());
@@ -240,7 +240,7 @@ TEST_F(AutofillDataTypeControllerTest, AbortWhileAssociatingNotActivated) {
wait_for_db_thread_pause.Wait();
EXPECT_EQ(DataTypeController::ASSOCIATING, autofill_dtc_->state());
- EXPECT_CALL(service_, DeactivateDataType(_, _)).Times(0);
+ EXPECT_CALL(service_, DeactivateDataType(_));
EXPECT_CALL(start_callback_, Run(DataTypeController::ABORTED, _));
autofill_dtc_->Stop();
EXPECT_EQ(DataTypeController::NOT_RUNNING, autofill_dtc_->state());
@@ -269,7 +269,7 @@ TEST_F(AutofillDataTypeControllerTest, AbortWhileAssociatingActivated) {
// ActivateDataType() before allowing it to continue.
WaitableEvent pause_db_thread(false, false);
WaitableEvent wait_for_db_thread_pause(false, false);
- EXPECT_CALL(service_, ActivateDataType(_, _)).
+ EXPECT_CALL(service_, ActivateDataType(_, _, _)).
WillOnce(DoAll(
SignalEvent(&wait_for_db_thread_pause),
WaitOnEvent(&pause_db_thread)));

Powered by Google App Engine
This is Rietveld 408576698