Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: remoting/webapp/me2mom/client_session.js

Issue 7511001: Don't transition to in-session mode until the connection has been established. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/me2mom/client_session.js
diff --git a/remoting/webapp/me2mom/client_session.js b/remoting/webapp/me2mom/client_session.js
index 553b423aa1b7a9ec669d7976dec1c9a25363da8b..4d332129b9106de1387a5b0d4d3e129148861815 100644
--- a/remoting/webapp/me2mom/client_session.js
+++ b/remoting/webapp/me2mom/client_session.js
@@ -111,6 +111,8 @@ remoting.ClientSession.prototype.createPluginAndConnect =
this.plugin.id = this.PLUGIN_ID;
this.plugin.src = 'about://none';
this.plugin.type = 'pepper-application/x-chromoting';
+ this.plugin.width = 0;
+ this.plugin.height = 0;
Jamie 2011/07/25 23:09:50 Although the plugin is blank until we transition t
container.appendChild(this.plugin);
if (!this.isPluginVersionSupported_(this.plugin)) {
@@ -320,10 +322,10 @@ remoting.ClientSession.prototype.connectionInfoUpdateCallback = function() {
* @return {void} Nothing.
*/
remoting.ClientSession.prototype.setState_ = function(state) {
- this.state = state;
if (this.onStateChange) {
- this.onStateChange(this.state);
+ this.onStateChange(state);
}
+ this.state = state;
Jamie 2011/07/25 23:09:50 Defer setting the current state so that the callba
awong 2011/07/26 18:51:27 Huh...We should document clearly that onStateChang
Jamie 2011/07/26 19:02:35 Yes, that's generally my preference too, but if th
};
/**

Powered by Google App Engine
This is Rietveld 408576698