Don't transition to in-session mode until the connection has been established.

remoting/webapp/me2mom/client_session.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Session class that handles creation and teardown of a remoting session.
  *
  * This abstracts a <embed> element and controls the plugin which does the
  * actual remoting work.  There should be no UI code inside this class.  It
@@ skipping 93 matching lines @@
  * @param {Element} container The element to add the plugin to.
  * @param {string} oauth2AccessToken A valid OAuth2 access token.
  * @return {void} Nothing.
  */
 remoting.ClientSession.prototype.createPluginAndConnect =
     function(container, oauth2AccessToken) {
   this.plugin = document.createElement('embed');
   this.plugin.id = this.PLUGIN_ID;
   this.plugin.src = 'about://none';
   this.plugin.type = 'pepper-application/x-chromoting';
+  this.plugin.width = 0;
+  this.plugin.height = 0;

[Jamie, 2011/07/25 23:09:50]

Although the plugin is blank until we transition to a new state, this feels like
the correct behaviour.

   container.appendChild(this.plugin);
 
   if (!this.isPluginVersionSupported_(this.plugin)) {
     // TODO(ajwong): Remove from parent.
     delete this.plugin;
     this.setState_(remoting.ClientSession.BAD_PLUGIN_VERSION);
     return;
   }
 
   var that = this;
@@ skipping 189 matching lines @@
   } else if (state == this.plugin.STATUS_FAILED) {
     this.setState_(remoting.ClientSession.State.CONNECTION_FAILED);
   }
 };
 
 /**
  * @param {remoting.ClientSession.State} state The new state for the session.
  * @return {void} Nothing.
  */
 remoting.ClientSession.prototype.setState_ = function(state) {
+  if (this.onStateChange) {
+    this.onStateChange(state);
+  }
   this.state = state;

[Jamie, 2011/07/25 23:09:50]

Defer setting the current state so that the callback can examine it.

[awong, 2011/07/26 18:51:27]

Huh...We should document clearly that onStateChange is a "pre-change" event. 
Normally, I code things post-change, but as long as we're consistent and clear
about the synchronization, either method works.

[Jamie, 2011/07/26 19:02:35]

Yes, that's generally my preference too, but if the callbacks needs both the
before and after states, pre-change makes more sense. I've added a comment.

-  if (this.onStateChange) {
-    this.onStateChange(this.state);
-  }
 };
 
 /**
  * This is a callback that gets called when the desktop size contained in the
  * the plugin has changed.
  *
  * @return {void} Nothing.
  */
 remoting.ClientSession.prototype.onDesktopSizeChanged_ = function() {
   var width = this.plugin.desktopWidth;
@@ skipping 23 matching lines @@
     'video_bandwidth': this.plugin.videoBandwidth,
     'capture_latency': this.plugin.videoCaptureLatency,
     'encode_latency': this.plugin.videoEncodeLatency,
     'decode_latency': this.plugin.videoDecodeLatency,
     'render_latency': this.plugin.videoRenderLatency,
     'roundtrip_latency': this.plugin.roundTripLatency
   };
 };
 
 }());