Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 751002: Fix Mac window frame coordinate conversion on multiple monitor setups (Closed)

Created:
10 years, 9 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix Mac window frame coordinate conversion on multiple monitor setups The same bug exists in our event coordinate conversion code in WebInputEventFactory, so this is half of a two-sided patch; WebKit side is: https://bugs.webkit.org/show_bug.cgi?id=35950 BUG=36621 TEST=In conjuction with the WebKit patch, mouseovers in Carbon plugins will work when the plugin is on a non-primary monitor with a different height than the primary monitor. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41516

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix another instance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M chrome/browser/automation/automation_provider_mac.mm View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stuartmorgan
10 years, 9 months ago (2010-03-09 23:06:38 UTC) #1
Avi (use Gerrit)
LG Since you comment that we need it in another place, I take it you ...
10 years, 9 months ago (2010-03-09 23:13:22 UTC) #2
stuartmorgan
http://codereview.chromium.org/751002/diff/1/2 File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right): http://codereview.chromium.org/751002/diff/1/2#newcode602 chrome/browser/renderer_host/render_widget_host_view_mac.mm:602: if ([[NSScreen screens] count] > 0) { On 2010/03/09 ...
10 years, 9 months ago (2010-03-09 23:23:35 UTC) #3
stuartmorgan
Updated to fix the instance in the automation provider as well.
10 years, 9 months ago (2010-03-10 15:36:40 UTC) #4
Avi (use Gerrit)
10 years, 9 months ago (2010-03-10 15:50:54 UTC) #5
SLGTM

Powered by Google App Engine
This is Rietveld 408576698