remoting/protocol/buffered_socket_writer.h - Issue 7508044: Remove video_channel() from Session interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/buffered_socket_writer.h

Issue 7508044: Remove video_channel() from Session interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: - Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/buffered_socket_writer.h

diff --git a/remoting/protocol/buffered_socket_writer.h b/remoting/protocol/buffered_socket_writer.h

index 46a3a7e8cdc560397fab6c57e18f53dbfa8d4424..3bb03d344e724681e8bd0a1d847ff2f75cafcf58 100644

--- a/remoting/protocol/buffered_socket_writer.h

+++ b/remoting/protocol/buffered_socket_writer.h

@@ -41,7 +41,8 @@ class BufferedSocketWriterBase

// Initializes the writer. Must be called on the thread that will be used

// to access the socket in the future. |callback| will be called after each

- // failed write.

+ // failed write. Caller retains ownership of |socket|.

+ // TODO(sergeyu): Change it so that it take ownership of |socket|.

void Init(net::Socket* socket, WriteFailedCallback* callback);

// Puts a new data chunk in the buffer. Returns false and doesn't enqueue