Profile Notifications: Fix all TOKEN_* in sync/

Profile Notifications: Fix all TOKEN_* in sync/

BUG=87457
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95458

[Roger Tawa OOO till Jul 10th, 2011-08-03 22:14:51]

http://codereview.chromium.org/7508035/diff/1/chrome/browser/sync/glue/sync_b...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/7508035/diff/1/chrome/browser/sync/glue/sync_b...
chrome/browser/sync/glue/sync_backend_host.cc:537:
Source<TokenService>(profile_->GetTokenService()),
are we sure that profile_->GetTokenService() will always return a non-NULL
pointer?  is it worth checking?

http://codereview.chromium.org/7508035/diff/1/chrome/common/chrome_notificati...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/7508035/diff/1/chrome/common/chrome_notificati...
chrome/common/chrome_notification_types.h:724: // The source is a TokenService
on the Profile. The details are a
please update comment here too, and any other token events as needed.

[Elliot Glaysher, 2011-08-03 22:42:29]

Undid change away from Profile.

http://codereview.chromium.org/7508035/diff/1/chrome/browser/sync/glue/sync_b...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/7508035/diff/1/chrome/browser/sync/glue/sync_b...
chrome/browser/sync/glue/sync_backend_host.cc:537:
Source<TokenService>(profile_->GetTokenService()),
On 2011/08/03 22:14:52, Roger Tawa wrote:
> are we sure that profile_->GetTokenService() will always return a non-NULL
> pointer?  is it worth checking?

IncognitoProfiles can return NULL, but they never create the sync service in the
first place.

Still, I only made this change to make the Source<> object the same as all the
other TOKEN_ notifications. Undone.

http://codereview.chromium.org/7508035/diff/1/chrome/common/chrome_notificati...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/7508035/diff/1/chrome/common/chrome_notificati...
chrome/common/chrome_notification_types.h:724: // The source is a TokenService
on the Profile. The details are a
On 2011/08/03 22:14:52, Roger Tawa wrote:
> please update comment here too, and any other token events as needed.

I'm not sure what you want me to do here. The Source<> is a TokenService.

[Roger Tawa OOO till Jul 10th, 2011-08-04 03:16:42]

lgtm

[tim (not reviewing), 2011-08-04 03:57:05]

LGTM, thanks.

[commit-bot: I haz the power, 2011-08-04 18:49:03]

Change committed as 95458