Make a pre-read A/B field-trial

chrome/browser/browser_main_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_main.h"
 #include "chrome/browser/browser_main_win.h"
 
 #include <windows.h>
 #include <shellapi.h>
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/i18n/rtl.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/scoped_native_library.h"
 #include "base/utf_string_conversions.h"
+#include "base/win/registry.h"  // For PreReadExperiment field-trial.
 #include "base/win/windows_version.h"
 #include "base/win/wrapped_window_proc.h"
 #include "chrome/browser/browser_util_win.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/metrics/metrics_service.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/views/uninstall_view.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_result_codes.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 59 matching lines @@
   FILETIME ignore = {};
   ::GetProcessTimes(::GetCurrentProcess(), &creation_time, &ignore, &ignore,
       &ignore);
 
   base::TimeDelta elapsed_from_startup =
       base::Time::Now() - base::Time::FromFileTime(creation_time);
 
   // Record the time to present in a histogram.
   UMA_HISTOGRAM_MEDIUM_TIMES("Startup.BrowserMessageLoopStartTime",
                              elapsed_from_startup);
+
+  // Create a sub-histogram based on the PreReadExperiment coin-toss.
+  base::win::RegKey key(HKEY_CURRENT_USER, L"Software\\Google\\ChromeFrame",

[Sigurður Ásgeirsson, 2011/08/04 13:35:32]

ditto: is there a good common place to put this reading? 

[chrisha, 2011/08/04 14:48:40]

I moved the common functionality to a function declared in browser_main_win.h.

+                        KEY_QUERY_VALUE);
+  DWORD pre_read = 1;
+  const char* uma_name = "Startup.BrowserMessageLoopStartTime_PreReadEnabled";
+  if (key.Valid())
+    key.ReadValueDW(L"PreReadExperiment", &pre_read);
+  if (pre_read == 0)
+    uma_name = "Startup.BrowserMessageLoopStartTime_PreReadDisabled";

[jar (doing other things), 2011/08/03 21:24:34]

personal preference nit: Same comment about refactoring as made in
browser_main.cc to avoid retyping the bulk of the histogram name.

(p.s., typos in these names have been historically bothersome... and sadly
common)

[chrisha, 2011/08/04 14:48:40]

Done.

+  UMA_HISTOGRAM_MEDIUM_TIMES(uma_name, elapsed_from_startup);
 }
 
 int AskForUninstallConfirmation() {
   int ret = content::RESULT_CODE_NORMAL_EXIT;
   views::Widget::CreateWindow(new UninstallView(ret))->Show();
   views::AcceleratorHandler accelerator_handler;
   MessageLoopForUI::current()->Run(&accelerator_handler);
   return ret;
 }
 
@@ skipping 206 matching lines @@
       crypto::EnsureNSPRInit();
     }
   }
 };
 
 // static
 BrowserMainParts* BrowserMainParts::CreateBrowserMainParts(
     const MainFunctionParams& parameters) {
   return new BrowserMainPartsWin(parameters);
 }