Switch virtual keyboard mode base on type of the current focused input field.

chrome/browser/resources/keyboard/main.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A simple virtual keyboard implementation.
  */
 
 /**
  * The keyboard layout name currently in use.
@@ skipping 147 matching lines @@
   var mainDiv = document.createElement('div');
   mainDiv.className = 'main';
   mainDiv.id = 'main';
   body.appendChild(mainDiv);
 
   initIme(mainDiv);
   initKeyboard(currentKeyboardLayout, mainDiv);
 
   window.onhashchange();
 
-  // Restore the keyboard to the default state when it is hidden.
-  // Ref: dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html
-  document.addEventListener("webkitvisibilitychange", function() {
-    if (document.webkitHidden) {
+  chrome.experimental.input.onTextInputTypeChanged.addListener(function(type) {

[mazda, 2011/08/04 02:15:36]

It might be better to enclose the sentence.

if (chrome.experimental) {
  chrome.experimental.input.onTextInputTypeChanged.addListener(function(type) {
...
}

+    var currentMode = KEY_MODE;

[bryeung, 2011/08/03 22:24:21]

don't shadow currentMode: it is a global JS variable here

[Peng, 2011/08/24 15:35:54]

Done.

+    switch(type) {

[bryeung, 2011/08/03 22:24:21]

I think the switch contents should be indented two spaces.

[Peng, 2011/08/24 15:35:54]

Done.

+    case "text":
       currentMode = SHIFT_MODE;
-      setMode(currentMode);
+      break;
+    case "password":
+    case "search":
+    case "url":
+      currentMode = KEY_MODE;
+      break;
+    case "number":
+    case "tel":
+      currentMode = NUMBER_MODE;
+      break;

[mazda, 2011/08/04 02:15:36]

It would be better to handle the default case as error.

[Peng, 2011/08/24 15:35:54]

Done.

     }
-  }, false);
+    setMode(currentMode);
+  });
 }
 // TODO(bryeung): would be nice to leave less gutter (without causing
 // rendering issues with floated divs wrapping at some sizes).
 
 /**
  * Switch the keyboard layout based on the current URL hash.
  * @return {void}
  */
 window.onhashchange = function() {
   var old_layout = currentKeyboardLayout;
@@ skipping 19 matching lines @@
       if (canvas !== undefined) {
         if (!visible) {
           canvas.clear();
         }
       }
       if (visible) {
         window.onresize();
       }
     });
 }