Switch virtual keyboard mode base on type of the current focused input field.

Switch virtual keyboard mode base on type of the current focused input field.


BUG=Virtual keyboard shouldn't remember state across different text fields.
TEST=Linux desktop


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98165

[Peng, 2011-08-03 17:40:28]

This CL depends on http://codereview.chromium.org/7553016/ .

[bryeung, 2011-08-03 22:24:21]

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/main.js (right):

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:169: var currentMode = KEY_MODE;
don't shadow currentMode: it is a global JS variable here

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:170: switch(type) {
I think the switch contents should be indented two spaces.

[bryeung, 2011-08-03 22:24:56]

You should get an LGTM from mazda@ as well, as he is now the primary developer
of this code.

[mazda, 2011-08-04 02:15:35]

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/main.js (right):

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:168:
chrome.experimental.input.onTextInputTypeChanged.addListener(function(type) {
It might be better to enclose the sentence.

if (chrome.experimental) {
  chrome.experimental.input.onTextInputTypeChanged.addListener(function(type) {
...
}

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:182: break;
It would be better to handle the default case as error.

[Peng, 2011-08-24 15:35:54]

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
File chrome/browser/resources/keyboard/main.js (right):

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:169: var currentMode = KEY_MODE;
On 2011/08/03 22:24:21, bryeung wrote:
> don't shadow currentMode: it is a global JS variable here

Done.

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:170: switch(type) {
On 2011/08/03 22:24:21, bryeung wrote:
> I think the switch contents should be indented two spaces.

Done.

http://codereview.chromium.org/7508025/diff/1/chrome/browser/resources/keyboa...
chrome/browser/resources/keyboard/main.js:182: break;
On 2011/08/04 02:15:36, mazda wrote:
> It would be better to handle the default case as error.

Done.

[bryeung, 2011-08-24 15:40:57]

LGTM

[mazda, 2011-08-24 20:07:31]

LGTM

[commit-bot: I haz the power, 2011-08-25 01:44:35]

Change committed as 98165