Add member variables to VirtualKeyboardSelector

Add member variables to VirtualKeyboardSelector and VirtualKeyboard classes.

This is necessary for implementing UI for virtual keyboard configuration. 

BUG=None
TEST=ran unit_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96703

[mazda, 2011-08-09 02:28:24]

http://codereview.chromium.org/7508014/diff/8001/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc
(right):

http://codereview.chromium.org/7508014/diff/8001/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc:23:
// Returns true if [start, end) contains all of the |urls|.
The comment sounds differently from the actual behavior.
For example, if [start, end) contains "aaa.com" and "bbb.com" and |urls| equals
to ["aaa.com"], the comment implies this function returns true, but actually
not.

[Yusuke Sato, 2011-08-09 05:25:49]

http://codereview.chromium.org/7508014/diff/8001/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc
(right):

http://codereview.chromium.org/7508014/diff/8001/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc:23:
// Returns true if [start, end) contains all of the |urls|.
On 2011/08/09 02:28:24, mazda wrote:
> The comment sounds differently from the actual behavior.
> For example, if [start, end) contains "aaa.com" and "bbb.com" and |urls|
equals
> to ["aaa.com"], the comment implies this function returns true, but actually
> not.

Done.

[Yusuke Sato, 2011-08-09 06:19:01]

simplified ChrckUrls following mazda's suggestion offline. Please take another
look.

On 2011/08/09 05:25:49, Yusuke Sato wrote:
>
http://codereview.chromium.org/7508014/diff/8001/chrome/browser/chromeos/inpu...
> File
chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc
> (right):
> 
>
http://codereview.chromium.org/7508014/diff/8001/chrome/browser/chromeos/inpu...
> chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc:23:
> // Returns true if [start, end) contains all of the |urls|.
> On 2011/08/09 02:28:24, mazda wrote:
> > The comment sounds differently from the actual behavior.
> > For example, if [start, end) contains "aaa.com" and "bbb.com" and |urls|
> equals
> > to ["aaa.com"], the comment implies this function returns true, but actually
> > not.
> 
> Done.

[mazda, 2011-08-09 06:40:46]

LGTM

The function became much easier to understand. Thanks!

[bryeung, 2011-08-12 17:08:07]

LGTM

[commit-bot: I haz the power, 2011-08-13 18:22:22]

Change committed as 96703