Issue 7508011: More fixes for PNaCl Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7508011: More fixes for PNaCl Windows. (Closed)

Created:
9 years, 4 months ago by pdox

Modified:
9 years, 4 months ago

Reviewers:
robertm, jvoung - send to chromium...

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Description

More fixes for PNaCl Windows. 1) pathtools.py: Do not treat '-' like a path. 2) untrusted_check/nacl.scons: On windows, the PNaCl tools return the full path in Cygwin-form. For example, /cygdrive/c/.../untrusted_check_test.c. Update the regex filter and golden stderr to handle this case correctly. 3) pnacl_abi filter regex was escaped with ', which doesn't work on Windows. Use " instead. 4) Change naclsdk.py to add .bat to tool paths on Windows. Previously, the .bat was being auto-detected by SCons, but this doesn't work when the tools are invoked directly. (as in pnacl_abi/nacl.scons) TBR= jvoung Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6300

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -12 lines)			Patch
M	site_scons/site_tools/naclsdk.py	View	1 chunk	+11 lines, -8 lines	0 comments	Download
M	tests/pnacl_abi/nacl.scons	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/untrusted_check/nacl.scons	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/untrusted_check/untrusted_check_test.stderr	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/llvm/driver/pathtools.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages