Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: test/mjsunit/enumeration-order.js

Issue 75035: Change the enumeration order for unsigned integer keys to always be... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/objects.cc ('K') | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 function check_enumeration_order(obj) { 28 function check_enumeration_order(obj) {
29 var value = 0; 29 var value = 0;
30 for (var name in obj) assertTrue(value < obj[name]); 30 for (var name in obj) assertTrue(value < obj[name]);
31 value = obj[name]; 31 value = obj[name];
32 } 32 }
33 33
34 function make_object(size) { 34 function make_object(size) {
35 var a = new Object(); 35 var a = new Object();
36 36
37 for (var i = 0; i < size; i++) a["a_" + i] = i + 1; 37 for (var i = 0; i < size; i++) a["a_" + i] = i + 1;
38 check_enumeration_order(a); 38 check_enumeration_order(a);
39 39
40 for (var i = 0; i < size; i +=3) delete a["a_" + i]; 40 for (var i = 0; i < size; i +=3) delete a["a_" + i];
41 check_enumeration_order(a); 41 check_enumeration_order(a);
42 } 42 }
43 43
44 // Validate the enumeration order for object up to 100 named properties. 44 // Validate the enumeration order for object up to 100 named properties.
45 for (var j = 1; j< 100; j++) make_object(j); 45 for (var j = 1; j< 100; j++) make_object(j);
46 46
47 47
48 function make_literal_object(size) { 48 function make_literal_object(size) {
49 var code = "{ "; 49 var code = "{ ";
50 for (var i = 0; i < size-1; i++) code += " a_" + i + " : " + (i + 1) + ", "; 50 for (var i = 0; i < size-1; i++) code += " a_" + i + " : " + (i + 1) + ", ";
51 code += "a_" + (size - 1) + " : " + size; 51 code += "a_" + (size - 1) + " : " + size;
52 code += " }"; 52 code += " }";
53 eval("var a = " + code); 53 eval("var a = " + code);
54 check_enumeration_order(a); 54 check_enumeration_order(a);
55 } 55 }
56 56
57 // Validate the enumeration order for object literals up to 100 named properties . 57 // Validate the enumeration order for object literals up to 100 named properties .
Kasper Lund 2009/04/16 11:22:04 Long line. Not your fault.
58 for (var j = 1; j< 100; j++) make_literal_object(j); 58 for (var j = 1; j< 100; j++) make_literal_object(j);
59 59
60 // We enumerate indexed properties in numerical order followed by
61 // named properties in insertion order, followed by indexed properties
62 // of the prototype object in numerical order, followed by named
63 // properties of the prototype object in insertion order, and so on.
64 //
65 // This enumeration order is not required by the specification, so
66 // this just documents our choice.
67 var proto2 = {};
68 proto2[140000] = 0;
69 proto2.a = 0;
70 proto2[2] = 0;
71 proto2[3] = 0; // also on the 'proto1' object
72 proto2.b = 0;
73 proto2[4294967295] = 0;
74 proto2.c = 0;
75 proto2[4294967296] = 0;
76
77 var proto1 = {};
78 proto1[5] = 0;
79 proto1.d = 0;
80 proto1[3] = 0;
81 proto1.e = 0;
82 proto1.f = 0; // also on the 'o' object
83
84 var o = {};
85 o[-23] = 0;
86 o[300000000000] = 0;
87 o[23] = 0;
88 o.f = 0;
89 o.g = 0;
90 o[-4] = 0;
91 o[42] = 0;
92
93 o.__proto__ = proto1;
94 proto1.__proto__ = proto2;
95
96 var expected = ['23', '42', // indexed from 'o'
97 '-23', '300000000000', 'f', 'g', '-4', // named from 'o'
98 '3', '5', // indexed from 'proto1'
99 'd', 'e', // named from 'proto1'
100 '2', '140000', '4294967295', // indexed from 'proto2'
101 'a', 'b', 'c', '4294967296']; // named from 'proto2'
102 var actual = [];
103 for (var p in o) actual.push(p);
104 assertArrayEquals(expected, actual);
105
106
107
108
OLDNEW
« src/objects.cc ('K') | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698