Change the enumeration order for unsigned integer keys to always be...

Change the enumeration order for unsigned integer keys to always be
numerical order independently of the representation of the object.

Exchanged the order of enumeration of integer and string keys so
integer keys are first instead of string keys to better match
WebKit/JSC behavior.

Added test cases that document our enumeration order choice.

Committed: http://code.google.com/p/v8/source/detail?r=1722

[Mads Ager (chromium), 2009-04-16 11:14:56]

http://codereview.chromium.org/75035/diff/1003/1007
File src/objects.cc (right):

http://codereview.chromium.org/75035/diff/1003/1007#newcode5140
Line 5140: if (!result.IsEmpty()) return true;
I have no idea why we treated an undefined result from an indexed property
getter as not being present.  I guess layout tests might tell us.  Running them
now.

[Kasper Lund, 2009-04-16 11:22:04]

LGTM.

http://codereview.chromium.org/75035/diff/1003/1007
File src/objects.cc (right):

http://codereview.chromium.org/75035/diff/1003/1007#newcode5885
Line 5885: (NumberToUint32(numbers->get(j-1)) >
j-1 -> j - 1

http://codereview.chromium.org/75035/diff/1003/1008
File src/objects.h (right):

http://codereview.chromium.org/75035/diff/1003/1008#newcode1589
Line 1589: // numbers array are equal, the elements are only swapped once.
equal -> identical (or the same object)

http://codereview.chromium.org/75035/diff/1003/1008#newcode1593
Line 1593: // numbers.  If the numbers array and the this array are equal, the
Again.

http://codereview.chromium.org/75035/diff/1003/1005
File test/mjsunit/enumeration-order.js (right):

http://codereview.chromium.org/75035/diff/1003/1005#newcode57
Line 57: // Validate the enumeration order for object literals up to 100 named
properties.
Long line. Not your fault.

[Mads Ager (chromium), 2009-04-16 11:29:04]

On 2009/04/16 11:22:04, Kasper Lund wrote:
> LGTM.
> 
> http://codereview.chromium.org/75035/diff/1003/1007
> File src/objects.cc (right):
> 
> http://codereview.chromium.org/75035/diff/1003/1007#newcode5885
> Line 5885: (NumberToUint32(numbers->get(j-1)) >
> j-1 -> j - 1

Done for all occurrences.

> http://codereview.chromium.org/75035/diff/1003/1008
> File src/objects.h (right):
> 
> http://codereview.chromium.org/75035/diff/1003/1008#newcode1589
> Line 1589: // numbers array are equal, the elements are only swapped once.
> equal -> identical (or the same object)
> 
> http://codereview.chromium.org/75035/diff/1003/1008#newcode1593
> Line 1593: // numbers.  If the numbers array and the this array are equal, the
> Again.

Yes, thanks.  I went for 'the same object'.

> http://codereview.chromium.org/75035/diff/1003/1005
> File test/mjsunit/enumeration-order.js (right):
> 
> http://codereview.chromium.org/75035/diff/1003/1005#newcode57
> Line 57: // Validate the enumeration order for object literals up to 100 named
> properties.
> Long line. Not your fault.

Fixed.