Support for guest signin and new user accounts in gaia signin screen.

Support for guest signin and new user accounts in gaia signin screen.

BUG=chromium-os:18665, chromium-os:18702
TEST=Should see createAccount/guestSignin links to the right of the gaia signin iframe. chrome://settings/accounts has checkboxes to control the visibility of these links. Clicking these links should work as you'd expect.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96232

[achuithb, 2011-08-10 20:41:53]

Please review. Thanks!

[xiyuan, 2011-08-10 20:52:53]

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.html (right):

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:9:
i18n-content="createAccount" onclick="chrome.send('createAccount');">
move onclick handler code into GaiaSigninScreen's decorate.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:10: Create a
Google Account
Remove this since we have i18n-content already.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:13:
i18n-content="guestSignin" onclick="chrome.send('launchIncognito');">
move onclick handler code into js.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:14: Browse as
Guest
Remove this.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:55:
console.log(data);
remove this debug code.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:65:
$('guestSignin').style.display = data.guestSignin ? '' : 'none';
$('createAccount').hidden = !data.createAccount;
$('guestSignin').hidden = !data.guestSignin;

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_signin.css (right):

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_signin.css:21: font-size: 12px;
alpha sort the list.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_signin.css:27: cursor: pointer;
alpha sort the list.

[achuithb, 2011-08-10 22:27:43]

Thanks for the comments. PTAL.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.html (right):

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:9:
i18n-content="createAccount" onclick="chrome.send('createAccount');">
On 2011/08/10 20:52:53, xiyuan wrote:
> move onclick handler code into GaiaSigninScreen's decorate.

Done.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:10: Create a
Google Account
On 2011/08/10 20:52:53, xiyuan wrote:
> Remove this since we have i18n-content already.

Done.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:13:
i18n-content="guestSignin" onclick="chrome.send('launchIncognito');">
On 2011/08/10 20:52:53, xiyuan wrote:
> move onclick handler code into js.

Done.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:14: Browse as
Guest
On 2011/08/10 20:52:53, xiyuan wrote:
> Remove this.

Done.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:55:
console.log(data);
On 2011/08/10 20:52:53, xiyuan wrote:
> remove this debug code.

Done.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:65:
$('guestSignin').style.display = data.guestSignin ? '' : 'none';
On 2011/08/10 20:52:53, xiyuan wrote:
> $('createAccount').hidden = !data.createAccount;
> $('guestSignin').hidden = !data.guestSignin;

Done.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/screen_signin.css (right):

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_signin.css:21: font-size: 12px;
On 2011/08/10 20:52:53, xiyuan wrote:
> alpha sort the list.

Done.

http://codereview.chromium.org/7497060/diff/6001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/screen_signin.css:27: cursor: pointer;
On 2011/08/10 20:52:53, xiyuan wrote:
> alpha sort the list.

Done.

[xiyuan, 2011-08-10 22:30:38]

LGTM

http://codereview.chromium.org/7497060/diff/10004/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.html (right):

http://codereview.chromium.org/7497060/diff/10004/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:12: </div>
nit: fix alignment of this and the line after.

[achuithb, 2011-08-10 22:34:39]

Thanks!

http://codereview.chromium.org/7497060/diff/10004/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.html (right):

http://codereview.chromium.org/7497060/diff/10004/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_gaia_signin.html:12: </div>
On 2011/08/10 22:30:38, xiyuan wrote:
> nit: fix alignment of this and the line after.

Done.