New windows opened in javascript with target = "_blank" should

content/browser/renderer_host/render_view_host_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/common/chrome_notification_types.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/browser/tab_contents/tab_contents_observer.h"
 #include "content/common/view_messages.h"
 #include "net/base/host_port_pair.h"
 #include "net/test/test_server.h"
 
 typedef std::pair<int, Value*> ExecuteDetailType;
@@ skipping 24 matching lines @@
   int id_;
   scoped_ptr<Value> value_;
 
   DISALLOW_COPY_AND_ASSIGN(ExecuteNotificationObserver);
 };
 
 }  // namespace
 
 class RenderViewHostTest : public InProcessBrowserTest {
  public:
-  RenderViewHostTest() : last_execute_id_(0) {}
+  RenderViewHostTest() : last_execute_id_(0) {
+    EnableDOMAutomation();
+  }
 
   void ExecuteJavascriptAndGetValue(const char* script,
                                     ExecuteNotificationObserver* out_result) {
     RenderViewHost* rvh =
         browser()->GetSelectedTabContents()->render_view_host();
     ASSERT_TRUE(rvh);
     int execute_id = rvh->ExecuteJavascriptInWebFrameNotifyResult(
         string16(),
         ASCIIToUTF16(script));
     EXPECT_NE(execute_id, last_execute_id_);
     ExecuteNotificationObserver observer;
     ui_test_utils::RegisterAndWait(
         out_result,
         content::NOTIFICATION_EXECUTE_JAVASCRIPT_RESULT,
         Source<RenderViewHost>(rvh));
     EXPECT_EQ(execute_id, out_result->id());
     ASSERT_TRUE(out_result->value());
     last_execute_id_ = execute_id;
   }
 
+ protected:
+  bool GetCreatedWindowName(const GURL& url,
+                            const wchar_t* function,
+                            std::string* window_name) {
+    ui_test_utils::NavigateToURL(browser(), url);
+
+    ui_test_utils::WindowedNotificationObserver observer(
+      chrome::NOTIFICATION_BROWSER_WINDOW_READY,
+      NotificationService::AllSources());
+
+    if (!ui_test_utils::ExecuteJavaScriptAndExtractString(
+          browser()->GetSelectedTabContents()->render_view_host(),
+          L"", function, window_name))
+      return false;
+
+    // observer.Wait();

[darin (slow to review), 2011/08/29 17:33:41]

why is this code commented out?

+    return true;
+  }
+
  private:
   int last_execute_id_;
 };
 
 
 // Makes sure ExecuteJavascriptInWebFrameNotifyResult works.
 IN_PROC_BROWSER_TEST_F(RenderViewHostTest,
                        ExecuteJavascriptInWebFrameNotifyResult) {
   ASSERT_TRUE(test_server()->Start());
   GURL empty_url(test_server()->GetURL("files/empty.html"));
@@ skipping 153 matching lines @@
   RenderViewHostTestTabContentsObserver observer(
       browser()->GetSelectedTabContents());
 
   GURL test_url = test_server()->GetURL("files/simple.html");
   ui_test_utils::NavigateToURL(browser(), test_url);
 
   EXPECT_EQ(test_server()->host_port_pair().ToString(),
             observer.observed_socket_address().ToString());
   EXPECT_EQ(1, observer.navigation_count());
 }
+
+// Regression test for http://crbug.com/88129
+IN_PROC_BROWSER_TEST_F(RenderViewHostTest, WindowOpen1) {
+  ASSERT_TRUE(test_server()->Start());
+
+  GURL url(test_server()->GetURL("files/window.open.blank.html"));
+  std::string window_name;
+  ASSERT_TRUE(GetCreatedWindowName(url, L"openWindow1();", &window_name));
+
+  EXPECT_EQ(window_name, "blank") << "Actual Window Name: " << window_name;
+}
+
+// Regression test for http://crbug.com/88129
+IN_PROC_BROWSER_TEST_F(RenderViewHostTest, WindowOpen2) {
+  ASSERT_TRUE(test_server()->Start());
+
+  GURL url(test_server()->GetURL("files/window.open.blank.html"));
+  std::string window_name;
+  ASSERT_TRUE(GetCreatedWindowName(url, L"openWindow2();", &window_name));
+
+  EXPECT_EQ(window_name, "") << "Actual Window Name: " << window_name;
+}