Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 7497040: Exclude some CrOS code that causes link errors on Windows incr. link (Closed)

Created:
9 years, 4 months ago by scottmg
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Exclude some CrOS code that causes link errors on Windows incr. link On Windows, when linking non-incrementally the functions that call the CrOS-only code are dead-stripped so there's no error, but with incremental linking the link fails. BUG=92171 TEST=Links on all platforms Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/extensions/extension_input_ime_api.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
9 years, 4 months ago (2011-08-10 00:01:32 UTC) #1
Zachary Kuznia
LGTM
9 years, 4 months ago (2011-08-10 04:00:10 UTC) #2
scottmg
On 2011/08/10 04:00:10, Zachary Kuznia wrote: > LGTM Thanks Zach, would you mind doing a ...
9 years, 4 months ago (2011-08-10 04:10:05 UTC) #3
Zachary Kuznia
I hit the commit check, the bot should push it. On Wed, Aug 10, 2011 ...
9 years, 4 months ago (2011-08-10 04:11:48 UTC) #4
scottmg
On 2011/08/10 04:11:48, Zachary Kuznia wrote: > I hit the commit check, the bot should ...
9 years, 4 months ago (2011-08-10 04:17:57 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-10 07:08:34 UTC) #6
Change committed as 96141

Powered by Google App Engine
This is Rietveld 408576698