refactor AudioInputDevice to remove race condition.

content/renderer/media/audio_input_message_filter.cc

Index: content/renderer/media/audio_input_message_filter.cc
===================================================================
--- content/renderer/media/audio_input_message_filter.cc	(revision 94305)
+++ content/renderer/media/audio_input_message_filter.cc	(working copy)
@@ -71,15 +71,17 @@
     base::FileDescriptor socket_descriptor,
 #endif
     uint32 length) {
+#if !defined(OS_WIN)
+  base::SyncSocket::Handle socket_handle = socket_descriptor.fd;

[henrika_dont_use, 2011/07/30 15:50:59]

Is this part required for this CL or is it "only", "nice to add while we are
fixing things"?

[wjia(left Chromium), 2011/08/01 22:40:13]

It's necessary to fix possible resource leakage. In case delegate has been
removed from filter before LowLatencyStreamCreated message arrives, both handles
will be lost.

+#endif
   Delegate* delegate = delegates_.Lookup(stream_id);
   if (!delegate) {
     DLOG(WARNING) << "Got audio stream event for a non-existent or removed"
         " audio capturer.";
+    base::SharedMemory::CloseHandle(handle);
+    base::SyncSocket socket(socket_handle);
     return;
   }
-#if !defined(OS_WIN)
-  base::SyncSocket::Handle socket_handle = socket_descriptor.fd;
-#endif
   // Forward message to the stream delegate.
   delegate->OnLowLatencyCreated(handle, socket_handle, length);
 }