Revert 94128 - [Sync] Refactor sync datatype error handling.

chrome/browser/sync/glue/preference_data_type_controller_unittest.cc

Index: chrome/browser/sync/glue/preference_data_type_controller_unittest.cc
===================================================================
--- chrome/browser/sync/glue/preference_data_type_controller_unittest.cc	(revision 94142)
+++ chrome/browser/sync/glue/preference_data_type_controller_unittest.cc	(working copy)
@@ -61,7 +61,7 @@
         WillRepeatedly(Return(true));
     EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)).
         WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true)));
-    EXPECT_CALL(*model_associator_, AssociateModels(_)).
+    EXPECT_CALL(*model_associator_, AssociateModels()).
         WillRepeatedly(Return(true));
   }
 
@@ -71,7 +71,7 @@
 
   void SetStopExpectations() {
     EXPECT_CALL(service_, DeactivateDataType(_, _));
-    EXPECT_CALL(*model_associator_, DisassociateModels(_));
+    EXPECT_CALL(*model_associator_, DisassociateModels());
   }
 
   MessageLoopForUI message_loop_;
@@ -119,9 +119,8 @@
 TEST_F(PreferenceDataTypeControllerTest, StartAssociationFailed) {
   SetStartExpectations();
   SetAssociateExpectations();
-  EXPECT_CALL(*model_associator_, AssociateModels(_)).
-      WillRepeatedly(DoAll(browser_sync::SetSyncError(syncable::PREFERENCES),
-                           Return(false)));
+  EXPECT_CALL(*model_associator_, AssociateModels()).
+      WillRepeatedly(Return(false));
 
   EXPECT_CALL(start_callback_, Run(DataTypeController::ASSOCIATION_FAILED, _));
   preference_dtc_->Start(NewCallback(&start_callback_, &StartCallback::Run));