Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/browser/sync/glue/data_type_manager.cc

Issue 7497014: Revert 94128 - [Sync] Refactor sync datatype error handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/data_type_manager.h ('k') | chrome/browser/sync/glue/data_type_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/data_type_manager.cc
===================================================================
--- chrome/browser/sync/glue/data_type_manager.cc (revision 94142)
+++ chrome/browser/sync/glue/data_type_manager.cc (working copy)
@@ -6,42 +6,12 @@
namespace browser_sync {
-DataTypeManager::ConfigureResult::ConfigureResult() {}
+DataTypeManager::ConfigureResultWithErrorLocation::
+ ~ConfigureResultWithErrorLocation() {}
-DataTypeManager::ConfigureResult::ConfigureResult(ConfigureStatus status,
- TypeSet requested_types)
- : status(status),
- requested_types(requested_types) {
- DCHECK_EQ(OK, status);
+DataTypeManager::ConfigureResultWithErrorLocation::
+ ConfigureResultWithErrorLocation()
+ : result(OK) {
}
-DataTypeManager::ConfigureResult::ConfigureResult(
- ConfigureStatus status,
- TypeSet requested_types,
- TypeSet failed_types,
- const tracked_objects::Location& location)
- : status(status),
- requested_types(requested_types),
- failed_types(failed_types),
- location(location) {
- DCHECK_NE(OK, status);
-}
-
-// Static.
-std::string DataTypeManager::ConfigureStatusToString(ConfigureStatus status) {
- switch (status) {
- case OK:
- return "Ok";
- case ASSOCIATION_FAILED:
- return "Association Failed";
- case ABORTED:
- return "Aborted";
- case UNRECOVERABLE_ERROR:
- return "Unrecoverable Error";
- default:
- NOTREACHED();
- return std::string();
- }
-}
-
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/data_type_manager.h ('k') | chrome/browser/sync/glue/data_type_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698