src/runtime.cc - Issue 7497010: Fix FixedDoubleArray crashes in chromebot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 7497010: Fix FixedDoubleArray crashes in chromebot (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: review feedback Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index e193dfc97710ba18b06d19282b011f9f6f87b372..ae1b67b41f0187d6373aeb64d34b4c1d2bab8dc8 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -220,7 +220,17 @@ MUST_USE_RESULT static MaybeObject* DeepCopyBoilerplate(Isolate* isolate,

break;

}

default:

- UNREACHABLE();

+ case JSObject::EXTERNAL_PIXEL_ELEMENTS:

Rico 2011/07/27 11:31:01 default: last?

+ case JSObject::EXTERNAL_BYTE_ELEMENTS:

+ case JSObject::EXTERNAL_UNSIGNED_BYTE_ELEMENTS:

+ case JSObject::EXTERNAL_SHORT_ELEMENTS:

+ case JSObject::EXTERNAL_UNSIGNED_SHORT_ELEMENTS:

+ case JSObject::EXTERNAL_INT_ELEMENTS:

+ case JSObject::EXTERNAL_UNSIGNED_INT_ELEMENTS:

+ case JSObject::EXTERNAL_FLOAT_ELEMENTS:

+ case JSObject::EXTERNAL_DOUBLE_ELEMENTS:

+ case JSObject::FAST_DOUBLE_ELEMENTS:

+ // No contained objects, nothing to do.

break;

}

return copy;

« no previous file with comments | « src/heap-inl.h ('k') | no next file » | no next file with comments »