Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: src/runtime.cc

Issue 7497010: Fix FixedDoubleArray crashes in chromebot (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 { MaybeObject* maybe_result = DeepCopyBoilerplate(isolate, 212 { MaybeObject* maybe_result = DeepCopyBoilerplate(isolate,
213 js_object); 213 js_object);
214 if (!maybe_result->ToObject(&result)) return maybe_result; 214 if (!maybe_result->ToObject(&result)) return maybe_result;
215 } 215 }
216 element_dictionary->ValueAtPut(i, result); 216 element_dictionary->ValueAtPut(i, result);
217 } 217 }
218 } 218 }
219 } 219 }
220 break; 220 break;
221 } 221 }
222 default: 222 case JSObject::NON_STRICT_ARGUMENTS_ELEMENTS:
223 UNREACHABLE(); 223 UNIMPLEMENTED();
224 break;
225 case JSObject::EXTERNAL_PIXEL_ELEMENTS:
226 case JSObject::EXTERNAL_BYTE_ELEMENTS:
227 case JSObject::EXTERNAL_UNSIGNED_BYTE_ELEMENTS:
228 case JSObject::EXTERNAL_SHORT_ELEMENTS:
229 case JSObject::EXTERNAL_UNSIGNED_SHORT_ELEMENTS:
230 case JSObject::EXTERNAL_INT_ELEMENTS:
231 case JSObject::EXTERNAL_UNSIGNED_INT_ELEMENTS:
232 case JSObject::EXTERNAL_FLOAT_ELEMENTS:
233 case JSObject::EXTERNAL_DOUBLE_ELEMENTS:
234 case JSObject::FAST_DOUBLE_ELEMENTS:
235 // No contained objects, nothing to do.
224 break; 236 break;
225 } 237 }
226 return copy; 238 return copy;
227 } 239 }
228 240
229 241
230 RUNTIME_FUNCTION(MaybeObject*, Runtime_CloneLiteralBoilerplate) { 242 RUNTIME_FUNCTION(MaybeObject*, Runtime_CloneLiteralBoilerplate) {
231 CONVERT_CHECKED(JSObject, boilerplate, args[0]); 243 CONVERT_CHECKED(JSObject, boilerplate, args[0]);
232 return DeepCopyBoilerplate(isolate, boilerplate); 244 return DeepCopyBoilerplate(isolate, boilerplate);
233 } 245 }
(...skipping 12517 matching lines...) Expand 10 before | Expand all | Expand 10 after
12751 } else { 12763 } else {
12752 // Handle last resort GC and make sure to allow future allocations 12764 // Handle last resort GC and make sure to allow future allocations
12753 // to grow the heap without causing GCs (if possible). 12765 // to grow the heap without causing GCs (if possible).
12754 isolate->counters()->gc_last_resort_from_js()->Increment(); 12766 isolate->counters()->gc_last_resort_from_js()->Increment();
12755 isolate->heap()->CollectAllGarbage(false); 12767 isolate->heap()->CollectAllGarbage(false);
12756 } 12768 }
12757 } 12769 }
12758 12770
12759 12771
12760 } } // namespace v8::internal 12772 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698