Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 7497008: Revert 93987 - Close the URL request in the destroctor. This ensures the load is actually (Closed)

Created:
9 years, 5 months ago by dpapad
Modified:
9 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 93987 - Close the URL request in the destroctor. This ensures the load is actually stopped when the request is deleted. This caused the pdf plugin to not display any pdf. TEST=manual BUG=84765 Review URL: http://codereview.chromium.org/7491046 TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webkit/plugins/ppapi/ppb_url_loader_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dpapad
9 years, 5 months ago (2011-07-26 08:55:48 UTC) #1
brettw
9 years, 5 months ago (2011-07-26 16:14:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698