Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: src/ia32/cpu-ia32.cc

Issue 7495025: Fix compilation error in ia32 platform valgrind tests. Error was introduced in r8721. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 60
61 // If flushing of the instruction cache becomes necessary Windows has the 61 // If flushing of the instruction cache becomes necessary Windows has the
62 // API function FlushInstructionCache. 62 // API function FlushInstructionCache.
63 63
64 // By default, valgrind only checks the stack for writes that might need to 64 // By default, valgrind only checks the stack for writes that might need to
65 // invalidate already cached translated code. This leads to random 65 // invalidate already cached translated code. This leads to random
66 // instability when code patches or moves are sometimes unnoticed. One 66 // instability when code patches or moves are sometimes unnoticed. One
67 // solution is to run valgrind with --smc-check=all, but this comes at a big 67 // solution is to run valgrind with --smc-check=all, but this comes at a big
68 // performance cost. We can notify valgrind to invalidate its cache. 68 // performance cost. We can notify valgrind to invalidate its cache.
69 #ifdef VALGRIND_DISCARD_TRANSLATIONS 69 #ifdef VALGRIND_DISCARD_TRANSLATIONS
70 VALGRIND_DISCARD_TRANSLATIONS(start, size); 70 unsigned res = VALGRIND_DISCARD_TRANSLATIONS(start, size);
71 USE(res);
71 #endif 72 #endif
72 } 73 }
73 74
74 75
75 void CPU::DebugBreak() { 76 void CPU::DebugBreak() {
76 #ifdef _MSC_VER 77 #ifdef _MSC_VER
77 // To avoid Visual Studio runtime support the following code can be used 78 // To avoid Visual Studio runtime support the following code can be used
78 // instead 79 // instead
79 // __asm { int 3 } 80 // __asm { int 3 }
80 __debugbreak(); 81 __debugbreak();
81 #else 82 #else
82 asm("int $3"); 83 asm("int $3");
83 #endif 84 #endif
84 } 85 }
85 86
86 } } // namespace v8::internal 87 } } // namespace v8::internal
87 88
88 #endif // V8_TARGET_ARCH_IA32 89 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698