9 years, 4 months ago
(2011-07-29 18:19:16 UTC)
#1
Miranda Callahan
On 2011/07/29 18:19:16, sail wrote: Sailesh, when I did this image drop, because the images ...
9 years, 4 months ago
(2011-07-29 19:34:42 UTC)
#2
On 2011/07/29 18:19:16, sail wrote:
Sailesh, when I did this image drop, because the images are a different size
(38x31 instead of 32x32), I saw lots of squishy distortion in fields that I had
to hack around. If it hadn't been for that, I would have made the drop myself
yesterday. Do you see this at all?
sail
On 2011/07/29 19:34:42, Miranda Callahan wrote: > On 2011/07/29 18:19:16, sail wrote: > > Sailesh, ...
9 years, 4 months ago
(2011-07-29 20:45:06 UTC)
#3
On 2011/07/29 19:34:42, Miranda Callahan wrote:
> On 2011/07/29 18:19:16, sail wrote:
>
> Sailesh, when I did this image drop, because the images are a different size
> (38x31 instead of 32x32), I saw lots of squishy distortion in fields that I
had
> to hack around.
Is this on Windows? If so what fields? The avatar button in the title bar on
Windows should display 38x31 icons just fine. We already use it to draw the
incognito icon which is also 38x31.
If this is not on Windows then I'm not too worried. As the UI changes I think
it's ok for the Mac/Linux UI to degrade temporarily.
mirandac
On Fri, Jul 29, 2011 at 16:45, <sail@chromium.org> wrote: > On 2011/07/29 19:34:42, Miranda Callahan ...
9 years, 4 months ago
(2011-07-29 22:25:22 UTC)
#4
On Fri, Jul 29, 2011 at 16:45, <sail@chromium.org> wrote:
> On 2011/07/29 19:34:42, Miranda Callahan wrote:
>
>> On 2011/07/29 18:19:16, sail wrote:
>>
>
> Sailesh, when I did this image drop, because the images are a different
>> size
>> (38x31 instead of 32x32), I saw lots of squishy distortion in fields that
>> I
>>
> had
>
>> to hack around.
>>
>
> Is this on Windows? If so what fields? The avatar button in the title bar
> on
> Windows should display 38x31 icons just fine. We already use it to draw the
> incognito icon which is also 38x31.
>
> If this is not on Windows then I'm not too worried. As the UI changes I
> think
> it's ok for the Mac/Linux UI to degrade temporarily.
I saw it on Windows, alas -- saw it in the UI you get to choose a different
profile avatar, specifically. Also saw it on the faces in the corner of the
frame -- if you look carefully, they are a wee bit squeezed. But in the UI
for choosing a new profile avatar, it's obvious...
>
>
>
http://codereview.chromium.**org/7493082/<http://codereview.chromium.org/7493...
>
sail
9 years, 4 months ago
(2011-08-03 19:37:36 UTC)
#5
Elliot Glaysher
This looks trivial. LGTM.
9 years, 4 months ago
(2011-08-03 19:41:40 UTC)
#6
Issue 7493082: Multi-Profiles: New Icon drop
(Closed)
Created 9 years, 4 months ago by sail
Modified 9 years, 3 months ago
Reviewers: Miranda Callahan, mirandac, Elliot Glaysher
Base URL: svn://svn.chromium.org/chrome/trunk/src/
Comments: 0