chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc - Issue 7493077: Add pref entry for virtual keyboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

Issue 7493077: Add pref entry for virtual keyboard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc ('K') | « chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc ('k') | chrome/browser/chromeos/preferences.h » ('j') | chrome/browser/chromeos/preferences.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc b/chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

index 8935f2c54e59b723cbfbe80939689dfd19e67ceb..834f309ea4fe17f728283d3ef0aabd386e8af533 100644

--- a/chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

+++ b/chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

@@ -371,9 +371,10 @@ TEST(VirtualKeyboardSelectorTest, TestSetUserPreferenceUserSystemMixed) {

system_virtual_keyboard_2.supported_layouts(),

system_virtual_keyboard_2.is_system());

- // Set and then remove user pref (=NOP).

+ // Set and then remove user prefs (=NOP).

EXPECT_TRUE(selector.SetUserPreference("a", GURL("http://system1")));

- selector.RemoveUserPreference("a");

+ EXPECT_TRUE(selector.SetUserPreference("z", GURL("http://system2")));

+ selector.ClearUserPreference();

bryeung 2011/08/03 22:15:40 There should still be a test for RemoveUserPrefere

Yusuke Sato 2011/08/04 07:34:50 Done.

// At this point, user_virtual_keyboard_2 has the highest priority.

ASSERT_TRUE(selector.SelectVirtualKeyboardWithoutPreferences("a"));