Unify the version string to be displayed on "About Chromium" dialog. (5/6)

Unify the version string to be displayed on "About Chromium" dialog. (5/6)

- Fetch Subversion URL and the revision from 'git log' even if git-svn is not available.
- Remove VersionInfo.root, since nobody is using it.
- Allow a user to specify the directory name just prior to the svn src URL.

FYI: We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the fifth step of them:

(1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony)
(2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark)
(3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony)
(4) Update version.bat to use lastchange.py. (reviewer: evan)
(5) Make changes to lastchange.py and webkit_version.py. (reviewer: evan, mark)
(6) Update tweak_info_plist to use lastchange.py. (reviewer: mark)

BUG=37186
TEST=Observe that "About Chromium" dialog shows the version string like "14.0.787.0 (Developer Build 88242 Windows" on Windows and Linux.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94828

[haraken1, 2011-07-29 04:47:49]

Would you please take a look?

mark: lastchange.py and webkit_version.py
evan: lastchange.py
tony: FYI

mark (in http://codereview.chromium.org/7104106/):
> version_info.root may now be obsolete. If so, you should remove it. Don’t do
> that in this change, please do it in a follow-up. We may also want to change
> _SVN_URL_REGEX at that time to be a regex that can be overridden by the user,
so
> that webkit_verison.py pushes in the “webkit” string instead of having it
> hard-coded.

Done in this patch.

[Mark Mentovai, 2011-07-29 13:47:58]

http://codereview.chromium.org/7493073/diff/1/build/util/lastchange.py
File build/util/lastchange.py (right):

http://codereview.chromium.org/7493073/diff/1/build/util/lastchange.py#newcod...
build/util/lastchange.py:182: global _SVN_URL_REGEX
It doesn’t make sense for this to be global any longer. Plumb it through to the
functions that need it as an argument.

[haraken1, 2011-07-29 14:01:32]

http://codereview.chromium.org/7493073/diff/1/build/util/lastchange.py
File build/util/lastchange.py (right):

http://codereview.chromium.org/7493073/diff/1/build/util/lastchange.py#newcod...
build/util/lastchange.py:182: global _SVN_URL_REGEX
On 2011/07/29 13:47:58, Mark Mentovai wrote:
> It doesn’t make sense for this to be global any longer. Plumb it through to
the
> functions that need it as an argument.

Done.

[Mark Mentovai, 2011-07-29 14:09:30]

LGTM largely on the basis of my previous review.

Please wait for Tony’s LG too as he had comments on this script in the previous
series.

[Evan Martin, 2011-07-29 17:01:40]

I am afraid of this change, because it changes a lot of code that has no test
coverage, and every time someone has changed this code it has broken the build
for someone.  Look at the history of this file to see the many ways it has been
broken.

With that said, fear is not a reason to block your change.  LGTM, and I am sorry
for how much trouble it has been.

[tony, 2011-07-29 17:08:40]

LGTM, just 2 small nits.  Please watch the tree when you land.

http://codereview.chromium.org/7493073/diff/2002/build/util/lastchange.py
File build/util/lastchange.py (right):

http://codereview.chromium.org/7493073/diff/2002/build/util/lastchange.py#new...
build/util/lastchange.py:177: directory_regex_prior_to_src_url=r'chrome|svn'):
Nit: Remove the 'r' before the string literal.

http://codereview.chromium.org/7493073/diff/2002/webkit/build/webkit_version.py
File webkit/build/webkit_version.py (right):

http://codereview.chromium.org/7493073/diff/2002/webkit/build/webkit_version....
webkit/build/webkit_version.py:62: directory_regex_prior_to_src_url=r'webkit')
Nit: Remove the 'r' before the string literal.

[commit-bot: I haz the power, 2011-07-30 05:34:50]

Change committed as 94828