Chromium Code Reviews| Index: presubmit_canned_checks.py |
| diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py |
| index a69bacee4ebd630a8377bfa1983b201e9be3e75b..08c8b2fdb8646e8d52fd15ff618cb9c3e2e69580 100644 |
| --- a/presubmit_canned_checks.py |
| +++ b/presubmit_canned_checks.py |
| @@ -66,8 +66,10 @@ def CheckChangeHasDescription(input_api, output_api): |
| def CheckChangeWasUploaded(input_api, output_api): |
| """Checks that the issue was uploaded before committing.""" |
| - if (input_api.is_committing and |
| - (not input_api.change.issue or not input_api.change.patchset)): |
| + if input_api.is_committing and not input_api.change.issue: |
| + # If patchset is None, it's likely a patched in issue directly from |
| + # Rietveld, e.g. a patch contributed by a non-committer that was patched in |
| + # by a committer to be checked-in. |
|
Dirk Pranke
2011/07/25 21:03:15
Okay, I follow the comment this time, but it is a
|
| return [output_api.PresubmitError( |
| 'Issue wasn\'t uploaded. Please upload first.')] |
| return [] |