Issue 7493032: Implemented CommandBuffer::GetState Graphics3D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7493032: Implemented CommandBuffer::GetState Graphics3D. (Closed)

Created:
9 years, 5 months ago by apatrick_chromium

Modified:
9 years, 5 months ago

Reviewers:
piman, alokp

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implemented CommandBuffer::GetState Graphics3D. I'm not sure how it worked without it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94001

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	ppapi/proxy/ppb_graphics_3d_proxy.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM. Shivers. It would be good fix gpu::CommandBuffer::GetLastState to be pure virtual assuming NaCl was ...

9 years, 5 months ago (2011-07-25 23:21:55 UTC) #4

apatrick_chromium

9 years, 5 months ago (2011-07-26 00:01:31 UTC) #5

On 2011/07/25 23:21:55, piman wrote:
> LGTM. Shivers.
> It would be good fix gpu::CommandBuffer::GetLastState to be pure virtual
> assuming NaCl was fixed.

That is exactly what I was doing when I discovered this :)

Expand Messages | Collapse Messages