Issue 7493030: Split WebMediaPlayerImpl::Proxy into its own class.

Issue 7493030: Split WebMediaPlayerImpl::Proxy into its own class. (Closed)

Created:
9 years, 5 months ago by scherkus (not reviewing)

Modified:
9 years, 4 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, commit-bot: I haz the power

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

Description

Split WebMediaPlayerImpl::Proxy into its own class. Trimmed some #includes and cleaned up some comments as well, but avoided functional changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96091

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : fixes #

Patch Set 4 : rebased #

Patch Set 5 : fixes #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+429 lines, -413 lines)			Patch
M	webkit/glue/media/video_renderer_impl.h	View	1 2 3 4	3 chunks	+17 lines, -24 lines	0 comments	Download
M	webkit/glue/media/video_renderer_impl.cc	View	1 2 3	3 chunks	+18 lines, -17 lines	0 comments	Download
M	webkit/glue/media/web_video_renderer.h	View	1 2 3 4	1 chunk	+7 lines, -3 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/glue/webmediaplayer_impl.h	View	1 2 3	5 chunks	+13 lines, -126 lines	0 comments	Download
M	webkit/glue/webmediaplayer_impl.cc	View	1 2 3	6 chunks	+8 lines, -242 lines	0 comments	Download
A	webkit/glue/webmediaplayer_proxy.h	View	1 2	1 chunk	+120 lines, -0 lines	0 comments	Download
A	webkit/glue/webmediaplayer_proxy.cc	View		1 chunk	+243 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

LGTM http://codereview.chromium.org/7493030/diff/2001/webkit/glue/webmediaplayer_impl.h File webkit/glue/webmediaplayer_impl.h (right): http://codereview.chromium.org/7493030/diff/2001/webkit/glue/webmediaplayer_impl.h#newcode33 webkit/glue/webmediaplayer_impl.h:33: // .------> Proxy <-----. Update diagram to reflect ...

9 years, 5 months ago (2011-07-27 16:03:03 UTC) #2

scherkus (not reviewing)

I'll land this post-other-changes and deal w/ the merges http://codereview.chromium.org/7493030/diff/2001/webkit/glue/webmediaplayer_impl.h File webkit/glue/webmediaplayer_impl.h (right): http://codereview.chromium.org/7493030/diff/2001/webkit/glue/webmediaplayer_impl.h#newcode33 webkit/glue/webmediaplayer_impl.h:33: ...

9 years, 5 months ago (2011-07-27 17:48:19 UTC) #3

commit-bot: I haz the power

9 years, 4 months ago (2011-08-09 22:39:25 UTC) #4

Can't apply patch for file webkit/glue/webmediaplayer_impl.cc.
While running patch -p1 --forward --force;
patching file webkit/glue/webmediaplayer_impl.cc
Hunk #5 FAILED at 229.
Hunk #6 succeeded at 300 (offset 3 lines).
1 out of 6 hunks FAILED -- saving rejects to file
webkit/glue/webmediaplayer_impl.cc.rej

Expand Messages | Collapse Messages