Instantiate OriginBoundCertService in relevant places and do plumbing to pass it down to HttpNetw...

chrome/browser/profiles/profile_io_data.h

Index: chrome/browser/profiles/profile_io_data.h
===================================================================
--- chrome/browser/profiles/profile_io_data.h	(revision 94628)
+++ chrome/browser/profiles/profile_io_data.h	(working copy)
@@ -39,6 +39,7 @@
 class DnsCertProvenanceChecker;
 class HttpTransactionFactory;
 class NetLog;
+class OriginBoundCertService;
 class ProxyConfigService;
 class ProxyService;
 class SSLConfigService;
@@ -207,6 +208,9 @@
     return chrome_url_data_manager_backend_.get();
   }
 
+  void set_origin_bound_cert_service(

[wtc, 2011/08/09 17:43:45]

It is important to point out that this is not a typical setter.

Please document that OriginBoundCertService is created by
a derived class of ProfileIOData and the derived class calls
this method to set the origin_bound_cert_service_ member
and transfers ownership to the base class.

An alternative design is to make origin_bound_cert_service_
a protected member.  But I am not sure if that's a good idea.

Question: does the forward declaration of OriginBoundCertService
prevent us from defining this method inline in the header?

[rkn, 2011/08/09 20:32:05]

Yes, the forward declaration seems to prevent us from inlining the method.

+      net::OriginBoundCertService* origin_bound_cert_service) const;
+
   net::NetworkDelegate* network_delegate() const {
     return network_delegate_.get();
   }
@@ -280,6 +284,7 @@
   // Pointed to by URLRequestContext.
   mutable scoped_ptr<ChromeURLDataManagerBackend>
       chrome_url_data_manager_backend_;
+  mutable scoped_ptr<net::OriginBoundCertService> origin_bound_cert_service_;
   mutable scoped_ptr<net::NetworkDelegate> network_delegate_;
   mutable scoped_ptr<net::DnsCertProvenanceChecker> dns_cert_checker_;
   mutable scoped_ptr<net::ProxyService> proxy_service_;