Issue 7492063: Removed wchat_t from Time::FromString.

Issue 7492063: Removed wchat_t from Time::FromString. (Closed)

Created:
9 years, 4 months ago by shinyak (Google)

Modified:
9 years, 4 months ago

Reviewers:
kinuko, commit-bot: I haz the power, brettw, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, kinuko+watch, Paweł Hajdan Jr.

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Removed wchat_t from Time::FromString. Also, some of the test case are moved for pr_time_unittests to time_unittests. BUG=77962 TEST=base_unittests:TimeTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95207

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+241 lines, -156 lines)			Patch
M	base/file_util_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/metrics/field_trial.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	base/pr_time_unittest.cc	View	2 chunks	+1 line, -117 lines	0 comments	Download
M	base/time.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/time.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	base/time_unittest.cc	View	7 chunks	+212 lines, -7 lines	0 comments	Download
M	chrome/browser/web_resource/promo_resource_service.cc	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/common/metrics_helpers.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/ftp/ftp_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_response_headers.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/http/http_response_headers_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/blob/blob_storage_controller_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/fileapi/file_system_dir_url_request_job_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 8 (0 generated)

shinyak (Google)

Unfortunately the previous Issue http://codereview.chromium.org/7470038/ was reverted, because of build failure. The reason was this ...

9 years, 4 months ago (2011-07-28 14:06:36 UTC) #1

commit-bot: I haz the power

Presubmit check for 7492063-1 failed and returned exit status 1. Running presubmit commit checks ...

9 years, 4 months ago (2011-08-01 14:04:26 UTC) #4

shinyak (Google)

Brett, Could you check this again? This is the same as the previous one except ...

9 years, 4 months ago (2011-08-01 15:10:39 UTC) #5

commit-bot: I haz the power

Try job failure for 7492063-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...

9 years, 4 months ago (2011-08-02 03:47:48 UTC) #7

Change committed as 95207