Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 7492059: HostResolver: don't interpret NULL callback argument as a request to do synchronous resolution. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged common code from Resolve and ResolveFromCache to a single function. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index 96796671064191f7b86d73d5e1ff73c5506f34b2..1a2825ed55391e4e41f35582bbd02be9162128c6 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -8861,26 +8861,29 @@ class OneTimeCachingHostResolver : public net::HostResolver {
AddressList* addresses,
CompletionCallback* callback,
RequestHandle* out_req,
- const BoundNetLog& net_log) {
- int rv = host_resolver_.Resolve(
+ const BoundNetLog& net_log) OVERRIDE {
+ return host_resolver_.Resolve(
info, addresses, callback, out_req, net_log);
- if (rv == OK && info.only_use_cached_response() &&
- info.host_port_pair().Equals(host_port_)) {
- // Discard cache.
+ }
+
+ virtual int ResolveFromCache(const RequestInfo& info,
+ AddressList* addresses,
+ const BoundNetLog& net_log) OVERRIDE {
+ int rv = host_resolver_.ResolveFromCache(info, addresses, net_log);
+ if (rv == OK && info.host_port_pair().Equals(host_port_))
host_resolver_.Reset(NULL);
- }
return rv;
}
- virtual void CancelRequest(RequestHandle req) {
+ virtual void CancelRequest(RequestHandle req) OVERRIDE {
host_resolver_.CancelRequest(req);
}
- virtual void AddObserver(Observer* observer) {
+ virtual void AddObserver(Observer* observer) OVERRIDE {
return host_resolver_.AddObserver(observer);
}
- virtual void RemoveObserver(Observer* observer) {
+ virtual void RemoveObserver(Observer* observer) OVERRIDE{
return host_resolver_.RemoveObserver(observer);
}

Powered by Google App Engine
This is Rietveld 408576698