Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 7492054: Don't send ViewMsg_ContextMenuClosed to the renderer process for submenus. (Closed)

Created:
9 years, 4 months ago by yzshen1
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, Avi (use Gerrit), Paweł Hajdan Jr., jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Don't send ViewMsg_ContextMenuClosed to the renderer process for submenus. Note: currently SimpleMenuModel::Delegate doesn't receive the same notifications on all platforms. On Windows and CrOS, MenuWillShow and MenuClosed are sent for all menus (including submenus); while these notifications are not sent for submenus on Linux (haven't tested Mac). This CL makes sure that on Windows and CrOS no ViewMsg_ContextMenuClosed messages are generated for submenus, but it doesn't unify the behavior of SimpleMenuModel::Delegate. I have filed a bug (http://code.google.com/p/chromium/issues/detail?id=90732) to track that issue. BUG=None TEST= - make sure you are running Pepper Flash on either CrOS or Windows; - go to www.hulu.com; - open context menu on the flash content; - move the cursor onto the Quality item to open a submenu; - move the cursor away; - the renderer process shouldn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94416

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M chrome/browser/tab_contents/render_view_context_menu.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_controller_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/button_dropdown_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ui/base/models/simple_menu_model.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/models/simple_menu_model.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yzshen1
Hi, Antoine. Would you please review this change? Thanks!
9 years, 4 months ago (2011-07-27 20:51:37 UTC) #1
piman
LGTM on the pepper side, but adding sky for the UI side, and brettw for ...
9 years, 4 months ago (2011-07-27 20:56:02 UTC) #2
brettw
tab contents LGTM
9 years, 4 months ago (2011-07-27 21:16:29 UTC) #3
sky
LGTM
9 years, 4 months ago (2011-07-27 23:46:42 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-07-28 02:15:11 UTC) #5
Change committed as 94416

Powered by Google App Engine
This is Rietveld 408576698