During SetupSync, check for missing passphrase before waiting for sync

During SetupSync, check for missing passphrase before waiting for sync

In SetupSync used by the sync integration tests, clients used to check
for a missing passphrase if initial sync failed, and return false if one
was required (indicating the fact that forward progress is impossible).

Due to a change in the sync startup flow, the check for a required
passphrase must now be done prior to waiting for initial sync.

This patch makes the above change, and thereby fixes the test case
SetPassphraseAndThenSetupSync that currently fails on the sync trybots.

TBR=zea@chromium.org
BUG=90371
TEST=sync_integration_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93873

[Raghu Simha, 2011-07-25 10:43:58]

Nicolas, please review when you get a chance -- I'm TBRing you on this patch.

I've tested the fix on all platforms, and will land it since it's affecting all
sync try jobs on all platforms.

[Raghu Simha, 2011-07-25 10:45:46]

Also, note that there are other failing tests on mac_sync that have to do with
mock keychain -- that issue is being fixed in another patch and has nothing to
do with this one.