Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 7492015: FTP: use an unmodified and more recent version of pyftpdlib fetched via DEPS (Closed)

Created:
9 years, 5 months ago by Paweł Hajdan Jr.
Modified:
9 years, 5 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

FTP: use an unmodified and more recent version of pyftpdlib fetched via DEPS This will make it much easier to update pyftpdlib and might help with FTP test flakiness. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93702

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10071 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +3 lines, -0 lines 1 comment Download
M net/test/test_server.cc View 1 chunk +4 lines, -3 lines 0 comments Download
D third_party/pyftpdlib/CREDITS View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/pyftpdlib/HISTORY View 1 chunk +0 lines, -216 lines 0 comments Download
D third_party/pyftpdlib/INSTALL View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/pyftpdlib/LICENSE View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/pyftpdlib/README View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/pyftpdlib/README.chromium View 1 chunk +3 lines, -7 lines 0 comments Download
D third_party/pyftpdlib/build/lib/pyftpdlib/ftpserver.py View 1 chunk +0 lines, -3127 lines 0 comments Download
D third_party/pyftpdlib/chromium.patch View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/pyftpdlib/demo/basic_ftpd.py View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/pyftpdlib/demo/md5_ftpd.py View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/pyftpdlib/demo/throttled_ftpd.py View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/pyftpdlib/demo/unix_ftpd.py View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/pyftpdlib/demo/winnt_ftpd.py View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/pyftpdlib/doc/adoptions.lnk.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/pyftpdlib/doc/faq.html View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/pyftpdlib/doc/index.html View 1 chunk +0 lines, -158 lines 0 comments Download
D third_party/pyftpdlib/doc/install.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/pyftpdlib/doc/release-notes.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/pyftpdlib/doc/rfcs-compliance.html View 1 chunk +0 lines, -720 lines 0 comments Download
D third_party/pyftpdlib/doc/roadmap.lnk.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/pyftpdlib/doc/tutorial.html View 1 chunk +0 lines, -329 lines 0 comments Download
D third_party/pyftpdlib/pyftpdlib/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/pyftpdlib/pyftpdlib/ftpserver.py View 1 chunk +0 lines, -3125 lines 0 comments Download
D third_party/pyftpdlib/setup.py View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/pyftpdlib/test/test_ftpd.py View 1 chunk +0 lines, -1623 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
This loses my earlier custom change making net_unittests slightly slower, but they are much slower ...
9 years, 5 months ago (2011-07-22 17:07:10 UTC) #1
wtc
LGTM. http://codereview.chromium.org/7492015/diff/1/DEPS File DEPS (right): http://codereview.chromium.org/7492015/diff/1/DEPS#newcode239 DEPS:239: "src/third_party/pyftpdlib/src": Nit: Should we list this new entry ...
9 years, 5 months ago (2011-07-22 18:19:54 UTC) #2
Nirnimesh
9 years, 5 months ago (2011-07-25 19:32:00 UTC) #3
You wouldn't believe in how many fanciful ways this has broken several bots.
I guess you cannot assume that the entire source tree is present on all our bots
through the DEPS mechanism. :(

Powered by Google App Engine
This is Rietveld 408576698