Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/mach_override/README.chromium

Issue 7492012: Lion x86 compatibility for mach_override (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/mach_override/LICENSE ('k') | third_party/mach_override/mach_override.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mach_override/README.chromium
===================================================================
--- third_party/mach_override/README.chromium (revision 93640)
+++ third_party/mach_override/README.chromium (working copy)
@@ -5,12 +5,11 @@
Date: 04/18/2011
Revision: 32c4560eb09848073f69
License: MIT
-Security Critical: Yes.
+Security Critical: Yes
Description:
-This is the mach_override part of the lastest (as of 04/11/2011) revision of
-mach_star, namely:
+This is the mach_override part of mach_star, namely:
https://github.com/rentzsch/mach_star/tree/aeb1720815c7255070da0f548267ccfdf7bd50b7
@@ -20,4 +19,21 @@
Local Modifications:
-None; all local changes have been upstreamed.
+Enabled makeIslandExecutable for 32-bit i386. Main executables linked and run
+on Mac OS X 10.7 ("Lion") have non-executable heap pages by default. See
+http://crbug.com/79642.
+
+Changed the logic surrounding calls to makeIslandExecutable so that
+mach_override_ptr can return successfully when originalFunctionReentryIsland,
+an optional argument, is NULL. Failure in makeIslandExecutable will now
+trigger cleanup of allocated memory.
+
+Changed allocateBranchIsland to use a more appropriate address range per
+http://developer.apple.com/library/mac/#documentation/Performance/Conceptual/LaunchTime/Articles/Prebinding.html.
+The range for x86 (32-bit) with kAllocateHigh set is now [0xffc00000,
+0xffe00000). In this configuration, the loop is now guaranteed to terminate
+instead of exceeding its permitted range. Previously, this function would
+begin looking for a page at 0xfefff000 and would not stop, even after wrapping
+around to low memory. The URL above states 0xfefff000 is within a range marked
+"Reserved for use by the pasteboard and other system services. Do not use this
+address range."
Property changes on: third_party/mach_override/README.chromium
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « third_party/mach_override/LICENSE ('k') | third_party/mach_override/mach_override.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698