Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 7492005: Fixes crash on startup with compact nav. A recent change meant it's (Closed)

Created:
9 years, 5 months ago by sky
Modified:
9 years, 5 months ago
Reviewers:
SteveT, Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes crash on startup with compact nav. A recent change meant it's possible for GetLocationBarView to be invoked before the compact nav classes have been created. This makes sure we don't crash if that happens. BUG=89843 TEST=none TBR=pkasting@chromium.org,stevet@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
9 years, 5 months ago (2011-07-22 04:02:09 UTC) #1
sky
I landed this fix, but this is still very fragile. I'll see about doing a ...
9 years, 5 months ago (2011-07-22 04:13:21 UTC) #2
SteveT
LGTM Out of curiosity, what was the change that introduced this crash? On 2011/07/22 04:13:21, ...
9 years, 5 months ago (2011-07-22 12:15:28 UTC) #3
sky
http://codereview.chromium.org/7358005/ The change made it so we can get a WM_MOVE earlier than we did ...
9 years, 5 months ago (2011-07-22 15:34:53 UTC) #4
Peter Kasting
I'm wondering why we're still fixing compact nav code when we decided to abandon it. ...
9 years, 5 months ago (2011-07-22 18:06:00 UTC) #5
SteveT
9 years, 5 months ago (2011-07-25 13:24:41 UTC) #6
I've filed a bug (crbug.com/89162) to track the removal of cnav. alcor@ and the
UI Leads wanted to take a different approach to compact nav, so we wanted to see
if some of this code can be reused.

I will chat with jeffreyc@ about pulling the flag so the first prototype is
inaccessible. Perhaps we'll also take the code out early as well, as there's
been no extra time spent on a new prototype yet.

Powered by Google App Engine
This is Rietveld 408576698