Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 7491100: Delete url_request_mock_net_error_job.*. (Closed)

Created:
9 years, 4 months ago by Evan Martin
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

Delete url_request_mock_net_error_job.*. As far as I can tell this code is unreferenced in the Chrome tree, and dates back to the initial commit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -188 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D content/browser/net/url_request_mock_net_error_job.h View 1 chunk +0 lines, -62 lines 0 comments Download
D content/browser/net/url_request_mock_net_error_job.cc View 1 chunk +0 lines, -124 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
Not sure I know what I'm doing, please double-check for me.
9 years, 4 months ago (2011-08-08 17:43:17 UTC) #1
darin (slow to review)
LGTM On Mon, Aug 8, 2011 at 10:43 AM, <evan@chromium.org> wrote: > Reviewers: darin, eroman, ...
9 years, 4 months ago (2011-08-08 17:56:41 UTC) #2
eroman
9 years, 4 months ago (2011-08-09 21:24:46 UTC) #3
LGTM (provided everything still compiles :)

Powered by Google App Engine
This is Rietveld 408576698