Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 7491099: Update base/android to use new ScopedJava(Global)Reference (Closed)

Created:
9 years, 4 months ago by steveblock
Modified:
9 years, 4 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Update base/android to use new ScopedJava(Global)Reference See http://src.chromium.org/viewvc/chrome?view=rev&revision=95821 BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96359

Patch Set 1 #

Patch Set 2 : Also fix license headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M base/android/jni_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/android/jni_array.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/android/jni_array.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M base/android/path_utils.cc View 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
steveblock
Tao, I could fox the headers in this directory as part of this change?
9 years, 4 months ago (2011-08-08 17:41:58 UTC) #1
michaelbai
Thanks LGTM (Not owner)
9 years, 4 months ago (2011-08-08 18:11:54 UTC) #2
brettw
LGTM
9 years, 4 months ago (2011-08-11 04:41:48 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-11 11:23:55 UTC) #4
Change committed as 96359

Powered by Google App Engine
This is Rietveld 408576698