Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7491097: Revert "Revert "Fix a bug in scope analysis."" (Closed)

Created:
9 years, 4 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Revert "Fix a bug in scope analysis."" Reapply r8838 with a fix for the issue of function names. Because function names can be added/changed/removed through the API, remember whether the function is anonymous when initially parsed and use that information when compiling. R=vegorov@chromium.org BUG=1583 TEST=regress-1583 Committed: http://code.google.com/p/v8/source/detail?r=8858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -101 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +19 lines, -18 lines 0 comments Download
M src/objects.h View 5 chunks +22 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +7 lines, -28 lines 0 comments Download
M src/parser.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/parser.cc View 10 chunks +29 lines, -25 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime.cc View 8 chunks +25 lines, -15 lines 0 comments Download
M src/v8natives.js View 3 chunks +5 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-1583.js View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 4 months ago (2011-08-08 16:00:29 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 4 months ago (2011-08-08 16:05:53 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698