Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4328)

Unified Diff: chrome/renderer/print_web_view_helper.h

Issue 7491074: Fix smelly scoped_ptr code in print_web_view_helper_win. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix win compile Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/print_web_view_helper_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/print_web_view_helper.h
diff --git a/chrome/renderer/print_web_view_helper.h b/chrome/renderer/print_web_view_helper.h
index dfc881c9cb64b4c8a8d57da6530002842caf326b..0407c85e111c4c67069c5d8c2e45732ffa400532 100644
--- a/chrome/renderer/print_web_view_helper.h
+++ b/chrome/renderer/print_web_view_helper.h
@@ -228,9 +228,14 @@ class PrintWebViewHelper : public RenderViewObserver,
// Platform specific helper function for rendering page(s) to |metafile|.
#if defined(OS_WIN)
- void RenderPage(const PrintMsg_Print_Params& params, float* scale_factor,
- int page_number, bool is_preview, WebKit::WebFrame* frame,
- scoped_ptr<printing::Metafile>* metafile);
+ // Because of mixed support for alpha channels on printers, this method may
+ // need to create a new metafile. The result may be either the passed
+ // |metafile| or a new one. In either case, the caller owns both |metafile|
+ // and the result.
+ printing::Metafile* RenderPage(const PrintMsg_Print_Params& params,
+ float* scale_factor, int page_number,
+ bool is_preview, WebKit::WebFrame* frame,
+ printing::Metafile* metafile);
#elif defined(OS_MACOSX)
void RenderPage(const gfx::Size& page_size, const gfx::Rect& content_area,
const float& scale_factor, int page_number,
« no previous file with comments | « no previous file | chrome/renderer/print_web_view_helper_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698