Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: remoting/host/capturer.h

Issue 7491070: Switch over to using SkRegions to calculate dirty areas. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleaned up comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/capturer.h
diff --git a/remoting/host/capturer.h b/remoting/host/capturer.h
index 5b9529423813ed4419003bf2d4cc9bf294c5ed5a..70dd1758a4fd29a82204b307124bc41efd1f3ed2 100644
--- a/remoting/host/capturer.h
+++ b/remoting/host/capturer.h
@@ -8,7 +8,7 @@
#include "base/basictypes.h"
#include "base/callback_old.h"
#include "remoting/base/capture_data.h"
-#include "remoting/base/types.h"
+#include "third_party/skia/include/core/SkRegion.h"
namespace remoting {
@@ -51,11 +51,11 @@ class Capturer {
// Return the pixel format of the screen.
virtual media::VideoFrame::Format pixel_format() const = 0;
- // Clear out the list of invalid rects.
- virtual void ClearInvalidRects() = 0;
+ // Clear out the invalid region.
+ virtual void ClearInvalidRegion() = 0;
- // Invalidate the specified screen rects.
- virtual void InvalidateRects(const InvalidRects& inval_rects) = 0;
+ // Invalidate the specified region.
+ virtual void InvalidateRegion(const SkRegion& inval_region) = 0;
Wez 2011/08/10 22:05:43 |inval_region|? ORLY?
// Invalidate the entire screen, of a given size.
virtual void InvalidateScreen(const gfx::Size& size) = 0;
@@ -65,19 +65,15 @@ class Capturer {
virtual void InvalidateFullScreen() = 0;
// Capture the screen data associated with each of the accumulated
- // rects in |inval_rects|.
- // This routine will first call CalculateInvalidRects to update the
- // list of |inval_rects|.
- // When the capture is complete, |callback| is called.
- //
- // If |inval_rects_| is empty, then this does nothing except
- // call the |callback| routine.
+ // dirty region.
+ // When the capture is complete, |callback| is called even If the dirty region
Wez 2011/08/10 22:05:43 nit: "If" -> "if".
+ // is empty.
//
// It is OK to call this method while another thread is reading
// data of the last capture.
Wez 2011/08/10 22:05:43 nit: "last"->"previous".
// There can be at most one concurrent read going on when this
// method is called.
- virtual void CaptureInvalidRects(CaptureCompletedCallback* callback) = 0;
+ virtual void CaptureInvalidRegion(CaptureCompletedCallback* callback) = 0;
// Get the size of the most recently captured screen.
virtual const gfx::Size& size_most_recent() const = 0;

Powered by Google App Engine
This is Rietveld 408576698