Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10298)

Unified Diff: chrome/test/live_sync/performance/extensions_sync_perf_test.cc

Issue 7491062: Sync performance test: Remove disabled benchmark tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/live_sync/performance/extensions_sync_perf_test.cc
diff --git a/chrome/test/live_sync/performance/extensions_sync_perf_test.cc b/chrome/test/live_sync/performance/extensions_sync_perf_test.cc
index 7b74cbfb56efaca996664dd83d43a4791564c422..492d966e207a5580b425e44f384da82b6cecd7c0 100644
--- a/chrome/test/live_sync/performance/extensions_sync_perf_test.cc
+++ b/chrome/test/live_sync/performance/extensions_sync_perf_test.cc
@@ -20,13 +20,7 @@ using extensions_helper::UninstallExtension;
// TODO(braffert): Replicate these tests for apps.
-// TODO(braffert): Move kNumBenchmarkPoints and kBenchmarkPoints for all
-// datatypes into a performance test base class, once it is possible to do so.
static const int kNumExtensions = 150;
-static const int kNumBenchmarkPoints = 18;
-static const int kBenchmarkPoints[] = {1, 10, 20, 30, 40, 50, 75, 100, 125,
- 150, 175, 200, 225, 250, 300, 350, 400,
- 500};
class ExtensionsSyncPerfTest : public LiveSyncTest {
public:
@@ -46,10 +40,6 @@ class ExtensionsSyncPerfTest : public LiveSyncTest {
// Returns the number of currently installed extensions for |profile|.
int GetExtensionCount(int profile);
- // Uninstalls all extensions from all profiles. Called between benchmark
- // iterations.
- void Cleanup();
-
private:
int extension_number_;
DISALLOW_COPY_AND_ASSIGN(ExtensionsSyncPerfTest);
@@ -85,14 +75,6 @@ void ExtensionsSyncPerfTest::RemoveExtensions(int profile) {
}
}
-void ExtensionsSyncPerfTest::Cleanup() {
- for (int i = 0; i < num_clients(); ++i) {
- RemoveExtensions(i);
- }
- ASSERT_TRUE(AwaitQuiescence());
- ASSERT_TRUE(AllProfilesHaveSameExtensions());
-}
-
IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, P0) {
ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
int num_default_extensions = GetExtensionCount(0);
@@ -118,31 +100,3 @@ IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, P0) {
ASSERT_EQ(num_default_extensions, GetExtensionCount(1));
SyncTimingHelper::PrintResult("extensions", "delete_extensions", dt);
}
-
-IN_PROC_BROWSER_TEST_F(ExtensionsSyncPerfTest, DISABLED_Benchmark) {
- ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
-
- for (int i = 0; i < kNumBenchmarkPoints; ++i) {
- int num_extensions = kBenchmarkPoints[i];
- AddExtensions(0, num_extensions);
- base::TimeDelta dt_add =
- SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
- InstallExtensionsPendingForSync(GetProfile(1));
- VLOG(0) << std::endl << "Add: " << num_extensions << " "
- << dt_add.InSecondsF();
-
- UpdateExtensions(0);
- base::TimeDelta dt_update =
- SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
- VLOG(0) << std::endl << "Update: " << num_extensions << " "
- << dt_update.InSecondsF();
-
- RemoveExtensions(0);
- base::TimeDelta dt_delete =
- SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
- VLOG(0) << std::endl << "Delete: " << num_extensions << " "
- << dt_delete.InSecondsF();
-
- Cleanup();
- }
-}

Powered by Google App Engine
This is Rietveld 408576698