Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: chrome/test/live_sync/performance/autofill_sync_perf_test.cc

Issue 7491062: Sync performance test: Remove disabled benchmark tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/live_sync/performance/autofill_sync_perf_test.cc
diff --git a/chrome/test/live_sync/performance/autofill_sync_perf_test.cc b/chrome/test/live_sync/performance/autofill_sync_perf_test.cc
index 62df13167168a65c3c17aeacaec418029bd823d6..a915b06c33d2128e64b60b6eb4bc5cc0bf70240c 100644
--- a/chrome/test/live_sync/performance/autofill_sync_perf_test.cc
+++ b/chrome/test/live_sync/performance/autofill_sync_perf_test.cc
@@ -20,14 +20,8 @@ using autofill_helper::GetProfileCount;
using autofill_helper::RemoveKey;
using autofill_helper::SetProfiles;
-// TODO(braffert): Move kNumBenchmarkPoints and kBenchmarkPoints for all
-// datatypes into a performance test base class, once it is possible to do so.
static const int kNumKeys = 150;
static const int kNumProfiles = 150;
-static const int kNumBenchmarkPoints = 18;
-static const int kBenchmarkPoints[] = {1, 10, 20, 30, 40, 50, 75, 100, 125,
- 150, 175, 200, 225, 250, 300, 350, 400,
- 500};
class AutofillSyncPerfTest : public LiveSyncTest {
public:
@@ -52,10 +46,6 @@ class AutofillSyncPerfTest : public LiveSyncTest {
// Removes all autofill keys from |profile|.
void RemoveKeys(int profile);
- // Removes all autofill profiles in all sync profiles. Called between
- // benchmark iterations.
- void Cleanup();
-
private:
// Returns a new unique autofill profile.
const AutofillProfile NextAutofillProfile();
@@ -133,13 +123,6 @@ void AutofillSyncPerfTest::RemoveKeys(int profile) {
}
}
-void AutofillSyncPerfTest::Cleanup() {
- for (int i = 0; i < num_clients(); ++i) {
- RemoveProfiles(i);
- }
- ASSERT_TRUE(AwaitQuiescence());
-}
-
const AutofillProfile AutofillSyncPerfTest::NextAutofillProfile() {
AutofillProfile profile;
autofill_test::SetProfileInfoWithGuid(&profile, NextGUID().c_str(),
@@ -213,36 +196,3 @@ IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, Autofill_P0) {
ASSERT_EQ(0, GetKeyCount(1));
SyncTimingHelper::PrintResult("autofill", "delete_autofill_keys", dt);
}
-
-IN_PROC_BROWSER_TEST_F(AutofillSyncPerfTest, DISABLED_Benchmark) {
- ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
-
- for (int i = 0; i < kNumBenchmarkPoints; ++i) {
- int num_profiles = kBenchmarkPoints[i];
- AddProfiles(0, num_profiles);
- base::TimeDelta dt_add =
- SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
- ASSERT_EQ(num_profiles, GetProfileCount(0));
- ASSERT_TRUE(AllProfilesMatch());
- VLOG(0) << std::endl << "Add: " << num_profiles << " "
- << dt_add.InSecondsF();
-
- UpdateProfiles(0);
- base::TimeDelta dt_update =
- SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
- ASSERT_EQ(num_profiles, GetProfileCount(0));
- ASSERT_TRUE(AllProfilesMatch());
- VLOG(0) << std::endl << "Update: " << num_profiles << " "
- << dt_update.InSecondsF();
-
- RemoveProfiles(0);
- base::TimeDelta dt_delete =
- SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));
- ASSERT_EQ(0, GetProfileCount(0));
- ASSERT_TRUE(AllProfilesMatch());
- VLOG(0) << std::endl << "Delete: " << num_profiles << " "
- << dt_delete.InSecondsF();
-
- Cleanup();
- }
-}
« no previous file with comments | « no previous file | chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698