Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 7491057: Make d8-os test less flaky. (Closed)

Created:
9 years, 4 months ago by Vitaly Repeshko
Modified:
9 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Make d8-os test less flaky. Because of stress testing there may be parallel instances of the test running, which makes it fail when using a hardcoded test dir name. Adding a random suffix helps. It'd be nicer to add something like pid, but there doesn't seem to be an easy way of getting it. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -84 lines) Patch
M test/mjsunit/d8-os.js View 2 chunks +89 lines, -84 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 4 months ago (2011-08-05 12:41:01 UTC) #1
Yang
9 years, 4 months ago (2011-08-05 12:57:13 UTC) #2
On 2011/08/05 12:41:01, Vitaly Repeshko wrote:

LGTM.

You may want to delete the last 4 lines in test/mjsunit/mjsunit.status though,
since this patch basically fixes that issue. Then again you may also want to
increase the random number range? If it is ran in parallel when testing
isolates, they will definitely run concurrently, and 1/65535 may still be a too
big chance?

Powered by Google App Engine
This is Rietveld 408576698