Issue 7491053: Fix DebugEvaluate crash within a catch in a function without local context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7491053: Fix DebugEvaluate crash within a catch in a function without local context. (Closed)

Created:
9 years, 4 months ago by Steven

Modified:
9 years, 4 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix DebugEvaluate crash within a catch in a function without local context. BUG=v8:1586 TEST=mjsunit/regress/regress-1586.js Committed: http://code.google.com/p/v8/source/detail?r=8844

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -1 line)			Patch
	M	src/runtime.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-1586.js	View		1 chunk	+64 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 4 months ago (2011-08-05 11:31:25 UTC) #2

LGTM.  Thanks.

http://codereview.chromium.org/7491053/diff/1/test/mjsunit/regress/regress-15...
File test/mjsunit/regress/regress-1586.js (right):

http://codereview.chromium.org/7491053/diff/1/test/mjsunit/regress/regress-15...
test/mjsunit/regress/regress-1586.js:56: // Set breakpoint on line 4.
This comment should be removed?

Expand Messages | Collapse Messages