Revert 95534 - Creat BrowsingDataCookieHelper and CannedBrowsingDataCookieHelper for logging cook...

Revert 95534 - Creat BrowsingDataCookieHelper and CannedBrowsingDataCookieHelper for logging cookies at UI thread.
BUG=XXX
TEST=XXX

Review URL: http://codereview.chromium.org/7355025

TBR=ycxiao@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95575

[ycxiao1, 2011-08-05 18:26:11]

Hello yzshen,

Thanks for noticing this leak and informing me!

It is my first time having a reverted CL.
Could you please tells me what should I do for this situation. Should I
changed the old CL and re-commit it, or I need to create a new CL for it?

Thanks!

Yancheng

On Fri, Aug 5, 2011 at 12:18 AM, <yzshen@chromium.org> wrote:

> Reviewers: ycxiao,
>
> Description:
> Revert 95534 - Creat BrowsingDataCookieHelper and
> CannedBrowsingDataCookieHelper
> for logging cookies at UI thread.
> BUG=XXX
> TEST=XXX
>
> Review URL:
http://codereview.chromium.**org/7355025<http://codereview.chromium.org/7355025>
>
> TBR=ycxiao@chromium.org
>
> Please review this at
http://codereview.chromium.**org/7491049/<http://codereview.chromium.org/7491...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  D     chrome/browser/browsing_data_**cookie_helper.h
>  D     chrome/browser/browsing_data_**cookie_helper.cc
>  D     chrome/browser/browsing_data_**cookie_helper_unittest.cc
>  M     chrome/browser/content_**settings/tab_specific_content_**settings.h
>  M     chrome/browser/content_**settings/tab_specific_content_**
> settings.cc
>  M     chrome/browser/cookies_tree_**model.h
>  M     chrome/browser/cookies_tree_**model.cc
>  M     chrome/browser/cookies_tree_**model_unittest.cc
>  D     chrome/browser/mock_browsing_**data_cookie_helper.h
>  D     chrome/browser/mock_browsing_**data_cookie_helper.cc
>  M     chrome/browser/safe_browsing/**client_side_detection_host_**
> unittest.cc
>  M     chrome/browser/ui/webui/**options/cookies_view_handler.**cc
>  M     chrome/chrome_browser.gypi
>  M     chrome/chrome_tests.gypi
>  M     net/base/cookie_monster.h
>  M     net/base/cookie_monster.cc
>
>
>

[wtc, 2011-08-08 20:57:41]

ycxiao: you should create a new CL.  Do not reuse the old CL.

Ideally, the new CL should start with the reverted changes.  Upload
it as Patch Set 1.  Then you make the change to fix the memory leak,
and upload a new patch set.  Doing it this way allows the code reviewer
to easily see what the memory leak fix is, by diff'ing between
patch sets.